[release/2.6] MIOpen: Get current device from Torch rather than HIP in handle creation #154549 #2216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e creation (pytorch#154549) Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file. Pull Request resolved: pytorch#154549 Approved by: https://github.com/jeffdaily, https://github.com/cyyever Co-authored-by: Jeff Daily <jeff.daily@amd.com>
apakbin
changed the title
Author
|
!cherry-pick --onto release/2.7 |
Author
|
!cherry-pick --onto rocm6.4_internal_testing |
Author
|
!cherry-pick --onto rocm6.5_internal_testing |
Collaborator
|
The cherry-pick keyword can be used only with the merged PRs |
2 similar comments
Collaborator
|
The cherry-pick keyword can be used only with the merged PRs |
Collaborator
|
The cherry-pick keyword can be used only with the merged PRs |
jerrymannil
approved these changes
Jun 2, 2025
pruthvistony
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a cherry-pick of pytorch#154549)
Get current device from Torch rather than HIP in MIOpen handle creation. The device may have already been set from torch side, otherwise device is set to 0 for handle. Additional audits of cudnn vs miopen Handle.cpp file.
Pull Request resolved: pytorch#154549
Approved by: https://github.com/jeffdaily, https://github.com/cyyever