Skip to content

Conversation

@ethanwee1
Copy link

@ethanwee1 ethanwee1 commented Jun 4, 2025

From upstream PR pytorch#154900
Resolves:https://ontrack-internal.amd.com/browse/SWDEV-536994

After following steps to reproduce in container registry-sc-harbor.amd.com/framework/compute-rocm-dkms-no-npi-hipclang:16231_ubuntu22.04_py3.10_pytorch_lw_release2.7_no_user_66a18277:

root@ubb4-rack-22:/var/lib/jenkins/pytorch# history
    1  cd /var/lib/jenkins/pytorch
    2  TEST_CONFIG=default CONTINUE_THROUGH_ERROR=True .ci/pytorch/test.sh

 Name:                    gfx90a
  Marketing Name:          AMD Instinct MI250X/MI250
+ MAYBE_ROCM=rocm/
+ [[ rocm == *xpu* ]]
+ [[ rocm != *-bazel-* ]]
+ pip_install ninja==1.10.2
+ pip_install_pkg='python3 -m pip install --progress-bar off'
+ python3 -m pip install --progress-bar off ninja==1.10.2
Collecting ninja==1.10.2
  Downloading ninja-1.10.2-py2.py3-none-manylinux_2_5_x86_64.manylinux1_x86_64.whl.metadata (5.0 kB)
Downloading ninja-1.10.2-py2.py3-none-manylinux_2_5_x86_64.manylinux1_x86_64.whl (108 kB)
Installing collected packages: ninja
  Attempting uninstall: ninja
    Found existing installation: ninja 1.11.1.4
    Uninstalling ninja-1.11.1.4:
      Successfully uninstalled ninja-1.11.1.4
Successfully installed ninja-1.10.2
+ export PATH=/root/.local/bin:/opt/venv/bin:/opt/rocm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ PATH=/root/.local/bin:/opt/venv/bin:/opt/rocm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ [[ rocm == *aarch64* ]]
+ [[ rocm == *asan* ]]
+ [[ rocm == *-debug* ]]
+ [[ rocm != *-bazel-* ]]
+ echo 'We are not in debug mode: rocm. Expect the assertion to pas

http://rocm-ci.amd.com/job/mainline-pytorch2.7-manylinux-wheels/126/

Cherry-picked to rocm7.0_internal_testing branch via #2282

Cherry-picked to rocm7.0_internal_testing branch via #2283

Cherry-picked to release/2.6 branch via #2284

@jithunnair-amd jithunnair-amd changed the title [release/2.7] removing --user flag [release/2.7] Removing --user flag from all pip install commands Jun 4, 2025
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jun 6, 2025

Jenkins build for 4e8efbc8ffafb2f1d083c5444c3cd224b80bec1e commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jun 16, 2025

Jenkins build for 36fd937315bc1c0c866a42dbba14d3b9b0d6fa29 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@ethanwee1 ethanwee1 force-pushed the release2.7_no_user branch from 187678f to 36fd937 Compare June 16, 2025 21:49
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jun 16, 2025

Jenkins build for 36fd937315bc1c0c866a42dbba14d3b9b0d6fa29 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jun 17, 2025

Jenkins build for 66a18277c53d92cbfc9ef2bca5117cb8fe17bf72 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@ethanwee1 ethanwee1 marked this pull request as ready for review June 18, 2025 14:47
@jithunnair-amd jithunnair-amd merged commit 0bd4030 into release/2.7 Jun 19, 2025
@jithunnair-amd jithunnair-amd deleted the release2.7_no_user branch June 19, 2025 05:32
@ethanwee1
Copy link
Author

! cherry-pick --onto rocm7.0_internal_testing

@ethanwee1
Copy link
Author

!cherry-pick --onto rocm7.0_internal_testing

@okakarpa
Copy link
Collaborator

Created branch autogenerated/rocm7.0_internal_testing_cherry-pick_pr-2238 and #2282. It contains a merge conflict. Please resolve it

@okakarpa
Copy link
Collaborator

Created branch autogenerated/rocm7.0_internal_testing_cherry-pick_pr-2238 and #2283. It contains a merge conflict. Please resolve it

@ethanwee1
Copy link
Author

!cherry-pick --onto release/2.6

@okakarpa
Copy link
Collaborator

Created branch autogenerated/release/2.6_cherry-pick_pr-2238 and #2284. It contains a merge conflict. Please resolve it

jithunnair-amd pushed a commit that referenced this pull request Jun 19, 2025
…ll commands (#2284)

Cherry-pick of #2238 

Mirror upstream release/2.6 to use same tlparse and remove all --user
flags

https://github.com/pytorch/pytorch/blob/1eba9b3aa3c43f86f4a2c807ac8e12c4a7767340/.ci/pytorch/common_utils.sh#L163

---------

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
jithunnair-amd pushed a commit that referenced this pull request Jun 19, 2025
…all pip install commands (#2283)

Cherry-pick of #2238

---------

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
@ethanwee1
Copy link
Author

!cherry-pick --onto release/2.5

@ethanwee1
Copy link
Author

! cherry-pick --onto release/2.5

ethanwee1 added a commit that referenced this pull request Aug 20, 2025
From upstream PR pytorch#154900
Resolves:https://ontrack-internal.amd.com/browse/SWDEV-536994

After following steps to reproduce in container
**registry-sc-harbor.amd.com/framework/compute-rocm-dkms-no-npi-hipclang:16231_ubuntu22.04_py3.10_pytorch_lw_release2.7_no_user_66a18277**:
```
root@ubb4-rack-22:/var/lib/jenkins/pytorch# history
    1  cd /var/lib/jenkins/pytorch
    2  TEST_CONFIG=default CONTINUE_THROUGH_ERROR=True .ci/pytorch/test.sh

 Name:                    gfx90a
  Marketing Name:          AMD Instinct MI250X/MI250
+ MAYBE_ROCM=rocm/
+ [[ rocm == *xpu* ]]
+ [[ rocm != *-bazel-* ]]
+ pip_install ninja==1.10.2
+ pip_install_pkg='python3 -m pip install --progress-bar off'
+ python3 -m pip install --progress-bar off ninja==1.10.2
Collecting ninja==1.10.2
  Downloading ninja-1.10.2-py2.py3-none-manylinux_2_5_x86_64.manylinux1_x86_64.whl.metadata (5.0 kB)
Downloading ninja-1.10.2-py2.py3-none-manylinux_2_5_x86_64.manylinux1_x86_64.whl (108 kB)
Installing collected packages: ninja
  Attempting uninstall: ninja
    Found existing installation: ninja 1.11.1.4
    Uninstalling ninja-1.11.1.4:
      Successfully uninstalled ninja-1.11.1.4
Successfully installed ninja-1.10.2
+ export PATH=/root/.local/bin:/opt/venv/bin:/opt/rocm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ PATH=/root/.local/bin:/opt/venv/bin:/opt/rocm/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ [[ rocm == *aarch64* ]]
+ [[ rocm == *asan* ]]
+ [[ rocm == *-debug* ]]
+ [[ rocm != *-bazel-* ]]
+ echo 'We are not in debug mode: rocm. Expect the assertion to pas
```
http://rocm-ci.amd.com/job/mainline-pytorch2.7-manylinux-wheels/126/

---------

Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
@dhonnappa-amd
Copy link

Can't perform the cherry-pick keyword: unexpected error

@dhonnappa-amd
Copy link

Comment processed by Build

@dhonnappa-amd
Copy link

Can't perform the cherry-pick keyword: unexpected error

@dhonnappa-amd
Copy link

Comment processed by Build

jeffdaily pushed a commit that referenced this pull request Aug 22, 2025
Cherry pick of #2238
Validation:

http://rocm-ci.amd.com/view/Release-7.0/job/pytorch2.5-manylinux-wheels_rel-7.0/34/

---------

Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants