Clean up CUDA state between tests #2296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for acea51aab3ae9c443b19a072ff7fa8791afe58a6 commit finished as FAILURE |
|
Jenkins build for acea51aab3ae9c443b19a072ff7fa8791afe58a6 commit finished as FAILURE |
pruthvistony
requested changes
Jul 8, 2025
|
Jenkins build for b00cb058f98e7a9c06f7c3f1a556e2ff2ff2cc7f commit finished as FAILURE |
|
Jenkins build for 7bff9c3008b162b45b6a53b96fdd3d3d1c2405cf commit finished as FAILURE |
|
Jenkins build for 7bff9c3008b162b45b6a53b96fdd3d3d1c2405cf commit is in progress |
pruthvistony
approved these changes
Jul 14, 2025
pruthvistony
merged commit fc804c3
into
ROCm:rocm7.0_internal_testing
0 of 2 checks passed
pragupta
pushed a commit
that referenced
this pull request
Oct 29, 2025
This PR fixes the unit test,
```
test/test_cuda.py::TestCuda::test_set_per_process_memory_fraction FAILED [0.1163s]
Traceback (most recent call last):
File "/var/lib/jenkins/pytorch/test/test_cuda.py", line 471, in test_set_per_process_memory_fraction
tmp_tensor = torch.empty(application, dtype=torch.int8, device="cuda")
RuntimeError: Trying to create tensor with negative dimension -5681285432: [-5681285432]
```
This error is specific to gfx1101 arch.
This error is coming from an integer overflow when another unit test,
`test/test_cuda.py::TestCuda::test_randint_generation_for_large_numel`
creates a tensor with a huge numel, which overflows into a higher
`torch.cuda.max_memory_reserved()` when you call
`test/test_cuda.py::TestCuda::test_set_per_process_memory_fraction`
afterward. To avoid this we introduced `torch.cuda.empty_cache()` and
`torch.cuda.reset_peak_memory_stats()` to clean up CUDA states.
JIRA: https://ontrack-internal.amd.com/browse/SWDEV-535295
(cherry picked from commit fc804c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the unit test,
This error is specific to gfx1101 arch.
This error is coming from an integer overflow when another unit test,
test/test_cuda.py::TestCuda::test_randint_generation_for_large_numelcreates a tensor with a huge numel, which overflows into a highertorch.cuda.max_memory_reserved()when you calltest/test_cuda.py::TestCuda::test_set_per_process_memory_fractionafterward. To avoid this we introducedtorch.cuda.empty_cache()andtorch.cuda.reset_peak_memory_stats()to clean up CUDA states.JIRA: https://ontrack-internal.amd.com/browse/SWDEV-535295