[release/2.5] fix and skip test_causal_variants on Navi4x #2304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for 4eb5066c7e862210b7fed7175f561d944e8a6c18 commit finished as FAILURE |
dnikolaev-amd
changed the title
pruthvistony
requested changes
Jul 8, 2025
| from torch.backends.cuda import ( | ||
| can_use_efficient_attention, | ||
| can_use_flash_attention, | ||
| cudnn_sdp_enabled, |
Collaborator
There was a problem hiding this comment.
are these imports not used? safe to remove?
Author
There was a problem hiding this comment.
There are no errors about unknown names in the tests
Also, I can't find any mention of these names:
- cudnn_sdp_enabled
- enable_cudnn_sdp
- enable_flash_sdp
- enable_math_sdp
- enable_mem_efficient_sdp
- flash_sdp_enabled
- math_sdp_enabled
- mem_efficient_sdp_enabled
|
Jenkins build for 4eb5066c7e862210b7fed7175f561d944e8a6c18 commit is in progress |
pruthvistony
approved these changes
Jul 21, 2025
pruthvistony
deleted the
dnikolaev/fix_test_causal_variants_navi4x_rel2.5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix test_transformers.py and skip one test:
NameError: name '_cur_sdpa_kernel_backends' is not definedtest_transformers.py::TestAttnBias::test_causal_variants_causal_variant_CausalVariant_UPPER_LEFT_shape3_cudaon Navi4x (tested on gfx1200 and gfx1201). Test failed on shape (1, 1, 23, 56, 15) only on Naxi4x only in release/2.5. Test useshipBlas, but switching tohipBlasLTdoesn't helprelease/2.6 has significant changes in
SDPBackend.MATHbackend and the test passesFixes SWDEV-522844