[AUTOGENERATED] [release/2.7] Improve C10_WARP_SIZE compatibility #2359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If compiling with HIPCC (i.e `__HIPCC__` is [defined](https://rocm.docs.amd.com/projects/HIP/en/docs-develop/how-to/hip_porting_guide.html#compiler-defines-summary)): * Define `C10_WARP_SIZE` to be non-constexpr `at::cuda::warp_size()` for host-compilation pass (as compared to `static constexpr int C10_WARP_SIZE = 1;` set in 538a57d) * Define `C10_WARP_SIZE` to be constexpr `64` for `__GFX9__`, and `32` otherwise, for device-compilation pass If not compiling with HIPCC: * Define `C10_WARP_SIZE` to be non-constexpr `at::cuda::warp_size()` For host-compilation cases where we need a constexpr value of warp size (eg. launch bounds), use `C10_WARP_SIZE_STATIC`, defined as `64` (Better to err on 64 for launch bounds) Fixes SWDEV-542227 --------- Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
|
Jenkins build for 5a66c3e64462ecc8a42eb16682d11e4d0ada04a7 commit finished as FAILURE |
jithunnair-amd
changed the title
ethanwee1
pushed a commit
that referenced
this pull request
Sep 10, 2025
) Cherry-pick of #2328 Co-authored-by: Xinya Zhang <Xinya.Zhang@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
ethanwee1
pushed a commit
that referenced
this pull request
Sep 10, 2025
) Cherry-pick of #2328 Co-authored-by: Xinya Zhang <Xinya.Zhang@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
ethanwee1
pushed a commit
that referenced
this pull request
Sep 11, 2025
) Cherry-pick of #2328 Co-authored-by: Xinya Zhang <Xinya.Zhang@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
ethanwee1
pushed a commit
that referenced
this pull request
Sep 11, 2025
) Cherry-pick of #2328 Co-authored-by: Xinya Zhang <Xinya.Zhang@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jithunnair-amd
added a commit
that referenced
this pull request
Sep 15, 2025
) Cherry-pick of #2328 Co-authored-by: Xinya Zhang <Xinya.Zhang@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jithunnair-amd
added a commit
that referenced
this pull request
Sep 15, 2025
) Cherry-pick of #2328 Co-authored-by: Xinya Zhang <Xinya.Zhang@amd.com> Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2328