[release/2.7][ROCm][tunableop] UT tolerance increase for matmul_small_brute_force_tunableop at FP16 #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tunableop at FP16 (pytorch#158788) TunableOp will sometimes find a less precise solution due to the small input vectors used in this UT. Bumping op tolerance to eliminate flakiness. Pull Request resolved: pytorch#158788 Approved by: https://github.com/jeffdaily (cherry picked from commit c917c63)
Author
|
Fixes, in part, SWDEV-535011. Tested locally. Will also cherry-pick to: |
|
Jenkins build for 5dd58a9194c53bf74c9c19fcaa57f2fc5c4cdee1 commit finished as FAILURE |
jeffdaily
approved these changes
Jul 23, 2025
Author
|
!cherry-pick --onto rocm7.0_internal_testing |
Author
|
!cherry-pick --onto rocm7.0_internal_testing_gfx950 |
okakarpa
pushed a commit
that referenced
this pull request
Jul 23, 2025
…_brute_force_… (#2397) TunableOp will sometimes find a less precise solution due to the small input vectors used in this UT. Bumping up tolerance to eliminate flakiness. Pull Request resolved: pytorch#158788 Approved by: https://github.com/jeffdaily (cherry picked from commit c917c63)
Collaborator
|
Created branch autogenerated/rocm7.0_internal_testing_cherry-pick_pr-2397 and #2399 |
okakarpa
pushed a commit
that referenced
this pull request
Jul 23, 2025
…_brute_force_… (#2397) TunableOp will sometimes find a less precise solution due to the small input vectors used in this UT. Bumping up tolerance to eliminate flakiness. Pull Request resolved: pytorch#158788 Approved by: https://github.com/jeffdaily (cherry picked from commit c917c63)
Collaborator
|
Created branch autogenerated/rocm7.0_internal_testing_gfx950_cherry-pick_pr-2397 and #2400 |
naromero77amd
changed the title
pragupta
pushed a commit
that referenced
this pull request
Jul 30, 2025
…_brute_force_… (#2397) TunableOp will sometimes find a less precise solution due to the small input vectors used in this UT. Bumping up tolerance to eliminate flakiness. Pull Request resolved: pytorch#158788 Approved by: https://github.com/jeffdaily (cherry picked from commit c917c63) (cherry picked from commit 35daec9)
jithunnair-amd
pushed a commit
that referenced
this pull request
Jul 31, 2025
…_brute_force_… (#2397) TunableOp will sometimes find a less precise solution due to the small input vectors used in this UT. Bumping up tolerance to eliminate flakiness. Pull Request resolved: pytorch#158788 Approved by: https://github.com/jeffdaily (cherry picked from commit c917c63) (cherry picked from commit 35daec9)
tvukovic-amd
pushed a commit
that referenced
this pull request
Aug 20, 2025
…_brute_force_… (#2397) TunableOp will sometimes find a less precise solution due to the small input vectors used in this UT. Bumping up tolerance to eliminate flakiness. Pull Request resolved: pytorch#158788 Approved by: https://github.com/jeffdaily (cherry picked from commit c917c63) (cherry picked from commit 35daec9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TunableOp will sometimes find a less precise solution due to the small input vectors used in this UT. Bumping up tolerance to eliminate flakiness.
Pull Request resolved: pytorch#158788
Approved by: https://github.com/jeffdaily
(cherry picked from commit c917c63)
Cherry-picked to rocm7.0_internal_testing branch via #2399
Cherry-picked to rocm7.0_internal_testing_gfx950 branch via #2400