Skip to content

Skip rowwise fp8 7.0 #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Skip rowwise fp8 7.0 #2445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50b748b
[rocm7.0_internal_testing] mx fpx: Skip test_blockwise_mxfloatx_error…
jagadish-amd Jul 31, 2025
1639e12
[rocm7.0_internal_testing] fp8: skip rowwise scaling tests
jagadish-amd Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/test_matmul_cuda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
parametrize,
run_tests,
skipIfRocm,
skipIfRocmArch,
skipIfRocmVersionLessThan,
TEST_CUDA,
TEST_WITH_ROCM,
Expand Down Expand Up @@ -907,6 +908,7 @@ def test_float8_scale_fast_accum(self, device) -> None:
out_fp8_s = torch._scaled_mm(x, y, scale_a=scale_a, scale_b=scale_b, use_fast_accum=True)
self.assertEqual(out_fp8, out_fp8_s)

@skipIfRocmArch("gfx950")
@unittest.skipIf(not PLATFORM_SUPPORTS_FP8 or IS_WINDOWS, f8_msg)
@unittest.skipIf(not SM89OrLater, "rowwise implementation is currently sm89+ specific")
@parametrize("use_fast_accum", [True, False])
Expand Down Expand Up @@ -1012,6 +1014,7 @@ def test_float8_error_messages(self, device) -> None:
out_dtype=torch.bfloat16,
)

@skipIfRocmArch("gfx950")
@unittest.skipIf(not PLATFORM_SUPPORTS_FP8 or IS_WINDOWS, f8_msg)
@unittest.skipIf(not SM89OrLater, "rowwise implementation is currently sm89+ specific")
@parametrize("base_dtype", [torch.bfloat16])
Expand Down Expand Up @@ -1382,6 +1385,7 @@ def test_blockwise_mxfp8_nvfp4_mxfp4_numerics(self, test_case_name, fast_accum,
sqnr = compute_error(C_ref, C)
assert sqnr.item() > approx_match_sqnr_target

@skipIfRocm
@unittest.skipIf(not PLATFORM_SUPPORTS_FP8 or IS_WINDOWS, f8_msg)
@parametrize("recipe", ["mxfp8", "nvfp4"])
def test_blockwise_mxfp8_nvfp4_error_messages(self, device, recipe) -> None:
Expand Down Expand Up @@ -1615,6 +1619,7 @@ def test_blockwise_mxfp8_compile(self) -> None:
)
torch.testing.assert_close(C, C_ref, atol=0, rtol=0)

@skipIfRocm
@unittest.skipIf(not PLATFORM_SUPPORTS_MX_GEMM, mx_skip_msg)
def test_blockwise_nvfp4_compile(self) -> None:

Expand Down