[release/2.8] fp8: skip rowwise tests #2477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fp8 rowwise scaling is not supported on ROCm 7.0 w/ gfx950, works on mainline. Skip the test for now. Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>
jagadish-amd
requested review from
BLOrange-AMD,
jithunnair-amd and
pruthvistony
|
Jenkins build for 4397a99d0253531f4439fb1468205d60f6888d80 commit finished as FAILURE |
pruthvistony
approved these changes
Aug 11, 2025
tvukovic-amd
pushed a commit
that referenced
this pull request
Aug 20, 2025
fp8 rowwise scaling is not supported on ROCm 7.0 w/ gfx950, works on mainline. Skip the test for now. Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fp8 rowwise scaling is not supported on ROCm 7.0 w/ gfx950, works on mainline.
Skip the test for now.