[release/2.8] Using c10d.barrier() in test_extra_cuda_context test in test_c10d_nccl.py #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext test in test_c10d_nccl.py (#2447) In this PR, I have removed a change made in commit 71a21d9 for test_extra_cuda_context test in test_c10d_nccl.py. Instead using c10d.barrier() to ensure that all nodes have completed init_process_group. We need this barrier to ensure that all nodes have completed init_process_group if rank=0 gets a mem snapshot before other nodes have finished init_process_group, then we artificially see a bump in memory usage. As per the following comment, we are going to be moving away from this function: pytorch#154174 (comment) Tested by building pytorch and running test_extra_cuda_context test with docker image: **compute-artifactory.amd.com:5000/rocm-plus-docker/framework/compute-rocm-rel-6.4:125_ubuntu24.04_py3.12_pytorch_rocm6.4_internal_testing_71a21d9**
|
Jenkins build for 029a4b4e76e9772e1386eb1e4146b8f28374c672 commit finished as FAILURE |
jeffdaily
changed the title
jeffdaily
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2447