[release/2.7][ROCm] Bug fix TunableOp validator UT. #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naromero77amd
requested review from
jeffdaily,
jithunnair-amd and
pruthvistony
|
Jenkins build for 6895c0f3da0eb84b9e83bec1fc9938efb4401eea commit finished as FAILURE |
jeffdaily
approved these changes
Aug 26, 2025
naromero77amd
changed the title
Author
|
!cherry-pick --onto rocm7.0_internal_testing |
dhonnappa-amd
pushed a commit
that referenced
this pull request
Aug 28, 2025
This is a partial cherry-pick from upstream: pytorch#158887 The TunableOp UT appears to fail with different versions of ROCm, but the real issue is the that regex in the UT is incorrect. @jeffdaily discovered this when we upgraded the nightly wheels to ROCm 6.4.2 in upstream PyTorch. Will resolve SWDEV-548689.
|
Created branch autogenerated/rocm7.0_internal_testing_cherry-pick_pr-2576 and #2588 Comment processed by Build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial cherry-pick from upstream: pytorch#158887
The TunableOp UT appears to fail with different versions of ROCm, but the real issue is the that regex in the UT is incorrect. @jeffdaily discovered this when we upgraded the nightly wheels to ROCm 6.4.2 in upstream PyTorch.
Will resolve SWDEV-548689.
Cherry-picked to rocm7.0_internal_testing branch via #2588