Performance script fix #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashveramd
pushed a commit
that referenced
this pull request
Jun 13, 2025
This PR is mainly to fix the spelling where activation checkpointing is missing an n... (**checkpoiting**). Not sure how I missed it earlier but it's glaring when you see the charts in visual form (vs text). <img width="578" alt="Screenshot 2024-04-24 at 2 45 25 PM" src="https://github.com/pytorch/torchtitan/assets/46302957/a81727b2-07b1-4d69-a0c1-743d74d2aa5a"> fixed: <img width="592" alt="Screenshot 2024-04-24 at 3 10 30 PM" src="https://github.com/pytorch/torchtitan/assets/46302957/769e51db-4aa6-4dbd-99d8-7e691658e280"> Also add a couple line breaks to help with layout, and one or two minor grammar updates.
skkkumar
pushed a commit
to skkkumar/pytorch
that referenced
this pull request
Jul 29, 2025
Commit Messages: - Fix build error (ROCm#264) (ROCm#265) Co-authored-by: Prachi Gupta <pracgupt@amd.com> PRs: - ROCm/apex#265 Fixes: - https://example.com/issue-264 - https://example.com/issue-265
skkkumar
pushed a commit
to skkkumar/pytorch
that referenced
this pull request
Jul 29, 2025
Commit Messages: - Fix build error (ROCm#264) (ROCm#265) Co-authored-by: Prachi Gupta <pracgupt@amd.com> PRs: - ROCm/apex#265 Fixes: - https://example.com/issue-265 - https://example.com/issue-264
skkkumar
pushed a commit
to skkkumar/pytorch
that referenced
this pull request
Jul 29, 2025
Commit Messages: - Fix build error (ROCm#264) (ROCm#265) Co-authored-by: Prachi Gupta <pracgupt@amd.com> PRs: - ROCm/apex#265 Fixes: - https://example.com/issue-265 - https://example.com/issue-264
skkkumar
pushed a commit
to skkkumar/pytorch
that referenced
this pull request
Jul 29, 2025
Commit Messages: - Fix build error (ROCm#264) (ROCm#265) Co-authored-by: Prachi Gupta <pracgupt@amd.com> PRs: - ROCm/apex#265 Fixes: - https://example.com/issue-265 - https://example.com/issue-264
skkkumar
pushed a commit
to skkkumar/pytorch
that referenced
this pull request
Jul 29, 2025
Commit Messages: - Fix build error (ROCm#264) (ROCm#265) Co-authored-by: Prachi Gupta <pracgupt@amd.com> PRs: - ROCm/apex#265 Fixes: - https://example.com/issue-264 - https://example.com/issue-265
amd-sriram
pushed a commit
that referenced
this pull request
Jul 29, 2025
Commit Messages: - Fix build error (#264) (#265) Co-authored-by: Prachi Gupta <pracgupt@amd.com> PRs: - ROCm/apex#265 Fixes: - https://example.com/issue-265 - https://example.com/issue-264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the model more comparable to other benchmarking models we use