Skip to content

[ROCm] Fix non-stride-one backwards indexing performance #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

[ROCm] Fix non-stride-one backwards indexing performance #2693

merged 1 commit into from
Oct 8, 2025

Conversation

@doru1004
Copy link

@doru1004 doru1004 commented Oct 3, 2025 •
edited by rocm-repo-management-api bot
Loading

Fix non-stride-one backwards indexing performance.
cherry-pick of pytorch#164409

Cherry-picked to release/2.7 branch via #2703

Cherry-picked to rocm7.1_internal_testing branch via #2704

Cherry-picked to release/2.9 branch via #2721

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Oct 3, 2025 •
edited
Loading

Jenkins build for cf04d856b001f90a9555958281fe5af1c06ac701 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

jerrymannil
jerrymannil reviewed Oct 7, 2025
View reviewed changes
jerrymannil
jerrymannil reviewed Oct 7, 2025
View reviewed changes
@doru1004 doru1004 force-pushed the fix-index-backward-perf branch from cf04d85 to 71ef8e9 Compare October 7, 2025 19:54
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Oct 7, 2025 •
edited
Loading

Jenkins build for deac2bae1a13eb0919211a427d5335b8ac28a615 commit finished as NOT_BUILT
Links: Blue Ocean view / Build artifacts

@doru1004 doru1004 force-pushed the fix-index-backward-perf branch from 71ef8e9 to deac2ba Compare October 7, 2025 21:08
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Oct 7, 2025 •
edited
Loading

Jenkins build for deac2bae1a13eb0919211a427d5335b8ac28a615 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jerrymannil jerrymannil merged commit fe1f5d7 into release/2.8 Oct 8, 2025
4 of 8 checks passed
@jerrymannil jerrymannil deleted the fix-index-backward-perf branch October 8, 2025 13:27
@jerrymannil
Copy link
Collaborator

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7

rocm-repo-management-api bot pushed a commit that referenced this pull request Oct 9, 2025
@doru1004
[ROCm] Fix non-stride-one backwards indexing performance (#2693)
4ba0bd5 
cherry-pick of pytorch#164409
@rocm-repo-management-api rocm-repo-management-api bot mentioned this pull request Oct 9, 2025
Merged
rocm-repo-management-api bot added a commit that referenced this pull request Oct 9, 2025
@rocm-repo-management-api @doru1004
[ROCm] Fix non-stride-one backwards indexing performance
018e50b 
Cherry-pick of #2693

Co-authored-by: Gheorghe-Teodor Bercea <gt.bercea@gmail.com>
@rocm-repo-management-api
Copy link

Created branch autogenerated/release/2.7_cherry-pick_pr-2693 and #2703

Comment processed by Build

@jerrymannil
Copy link
Collaborator

! cherry-pick --onto rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto release/2.7 rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@salvadorteranochoa
Copy link

! cherry-pick --onto rocm7.1_internal_testing

rocm-repo-management-api bot pushed a commit that referenced this pull request Oct 10, 2025
@doru1004
[ROCm] Fix non-stride-one backwards indexing performance (#2693)
8789df9 
cherry-pick of pytorch#164409
@rocm-repo-management-api rocm-repo-management-api bot mentioned this pull request Oct 10, 2025
Merged
@rocm-repo-management-api
Copy link

Created branch autogenerated/rocm7.1_internal_testing_cherry-pick_pr-2693 and #2704

Comment processed by Build

rocm-repo-management-api bot added a commit that referenced this pull request Oct 10, 2025
@rocm-repo-management-api @doru1004
[ROCm] Fix non-stride-one backwards indexing performance
20c7a39 
Cherry-pick of #2693

Co-authored-by: Gheorghe-Teodor Bercea <gt.bercea@gmail.com>
@salvadorteranochoa
Copy link

@jerrymannil apologies for the delay, still trying to fix this issue

@salvadorteranochoa
Copy link

! cherry-pick --onto rocm7.1_internal_testing

@rocm-repo-management-api
Copy link

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

@jerrymannil
Copy link
Collaborator

! cherry-pick --onto release/2.9

rocm-repo-management-api bot pushed a commit that referenced this pull request Oct 16, 2025
@doru1004
[ROCm] Fix non-stride-one backwards indexing performance (#2693)
813f4fd 
cherry-pick of pytorch#164409
@rocm-repo-management-api rocm-repo-management-api bot mentioned this pull request Oct 16, 2025
Merged
rocm-repo-management-api bot added a commit that referenced this pull request Oct 16, 2025
@rocm-repo-management-api @doru1004
[ROCm] Fix non-stride-one backwards indexing performance
4fe15f2 
Cherry-pick of #2693

Co-authored-by: Gheorghe-Teodor Bercea <gt.bercea@gmail.com>
@rocm-repo-management-api
Copy link

Created branch autogenerated/release/2.9_cherry-pick_pr-2693 and #2721

Comment processed by Build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerrymannil jerrymannil jerrymannil approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@doru1004 @jerrymannil @salvadorteranochoa