Skip to content

[release/2.9] remove amdgpu-coerce-illegal-types=1 #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
Merged

[release/2.9] remove amdgpu-coerce-illegal-types=1 #2720

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d854fd
find rocm version
ethanwee1 Oct 16, 2025
c48a240
Update CMakeLists.txt
ethanwee1 Oct 16, 2025
c20dcdf
Update CMakeLists.txt
ethanwee1 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions aten/src/ATen/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
cmake_minimum_required(VERSION 3.27 FATAL_ERROR)
set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake ${CMAKE_MODULE_PATH})
list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake/public")
if(USE_ROCM)
include(LoadHIP OPTIONAL RESULT_VARIABLE _had_loadhip)
if(_had_loadhip)
# Exposed by LoadHIP.cmake, e.g. "7.1.2" or "7.2.0"
message(STATUS "LoadHIP loaded: ROCM_VERSION_DEV='${ROCM_VERSION_DEV}'")
else()
message(WARNING "LoadHIP.cmake not found; ROCM_VERSION_DEV unavailable")
endif()
endif()

if(NOT MSVC)
string(APPEND CMAKE_CXX_FLAGS " -Wno-ignored-qualifiers")
Expand Down Expand Up @@ -301,13 +311,14 @@ IF(USE_FBGEMM_GENAI)

# Add additional HIPCC compiler flags for performance
set(FBGEMM_GENAI_EXTRA_HIPCC_FLAGS
-mllvm
-amdgpu-coerce-illegal-types=1
-mllvm
-enable-post-misched=0
-mllvm
-greedy-reverse-local-assignment=1
-fhip-new-launch-api)
if(DEFINED ROCM_VERSION_DEV AND ROCM_VERSION_DEV VERSION_LESS "7.2.0")
list(PREPEND FBGEMM_GENAI_EXTRA_HIPCC_FLAGS -mllvm -amdgpu-coerce-illegal-types=1)
endif()

hip_add_library(
fbgemm_genai STATIC
Expand Down