Skip to content

[NO CP] triton sanity check for 2D POI #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
Merged

[NO CP] triton sanity check for 2D POI #2798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b19458a
triton sanity check for 2D POI
AmdSampsa Nov 11, 2025
f8d0c10
blocksize check
AmdSampsa Nov 14, 2025
a453dea
blocksize check etc
AmdSampsa Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions torch/_inductor/runtime/triton_heuristics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2568,17 +2568,30 @@ def pointwise(
*hinted_configs,
]
if torch.version.hip:
configs += [ # add here
]
# bypass triton_config_with_settings -> triton_config logic
if "x" in size_hints and "y" in size_hints:
configs += [
Config({"XBLOCK": 512, "YBLOCK": 8}, num_warps=8), # wrt1/t21 # triton_poi_fused__unsafe_view_add_addmm_cat_clone_permute_split_with_sizes_view_19
Config({"XBLOCK": 32, "YBLOCK": 128}, num_warps=4), # wrt2: 570us : triton_poi_fused_add_transpose_view_52
Config({"XBLOCK":64, "YBLOCK": 32}, num_warps=8), # wrt3: 150us: triton_poi_fused__to_copy_add_native_layer_norm_native_layer_norm_backward_permute_view_103
Config({"XBLOCK":64, "YBLOCK": 256}, num_warps=4), # wri0: 70us: triton_poi_fused_clone_tanh_transpose_19
Config({"XBLOCK":512, "YBLOCK": 64}, num_warps=8), # wri0: 58us: triton_poi_fused_clone_53
]
"""add 2D tiling configs, but don't use triton_config_with_settings function
as it is buggy and might change the tiling randomly
"""
def addConfig__(xblock:int, yblock:int, num_warps:int, num_stages:int):
# only add a tiling config if size is bigger than the tile
# check also for grid overflow
xgrid = (size_hints["x"] + xblock - 1) // xblock
ygrid = (size_hints["y"] + yblock - 1) // yblock
if xgrid > 2147483647:
return
if ygrid > 65535:
return
if size_hints["x"] < xblock:
return
if size_hints["y"] < yblock:
return
# all good, add the config
configs.append(Config({"XBLOCK": xblock, "YBLOCK": yblock}, num_warps=num_warps, num_stages=num_stages))
addConfig__(512, 8, 8,1 ) # wrt1/t21 # triton_poi_fused__unsafe_view_add_addmm_cat_clone_permute_split_with_sizes_view_19
addConfig__(32, 128, 4, 1) # wrt2: 570us : triton_poi_fused_add_transpose_view_52
addConfig__(64, 32, 8, 1) # wrt3: 150us: triton_poi_fused__to_copy_add_native_layer_norm_native_layer_norm_backward_permute_view_103
addConfig__(64, 256, 4, 1) # wri0: 70us: triton_poi_fused_clone_tanh_transpose_19
addConfig__(512, 64, 8, 1) # wri0: 58us: triton_poi_fused_clone_53

if len(size_hints) == 3:
if disable_pointwise_autotuning(inductor_meta):
Expand Down