Use ck::half_t for Host Reduction#195
Merged
Merged
Conversation
asroy
reviewed
Apr 20, 2022
| @@ -245,7 +222,7 @@ binop_with_nan_check2(std::function<void(AccDataType&, AccDataType, bool&)> opRe | |||
| int& accuIndex, | |||
Contributor
There was a problem hiding this comment.
Is this tensor index? If so, index_t should be used.
Contributor
Author
There was a problem hiding this comment.
Yes, need correction
asroy
reviewed
Apr 20, 2022
| @@ -245,7 +222,7 @@ binop_with_nan_check2(std::function<void(AccDataType&, AccDataType, bool&)> opRe | |||
| int& accuIndex, | |||
| int currIndex) | |||
asroy
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This P.R is to remove the using of half_float::half in Host Reduction so that ck::half_t is used by Reduction on both the kernel and host. Some host math functions are added to support ck::half on host.