Skip to content

fix(ioctl): _IOR() overflows in switch (int) #10650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

fix(ioctl): _IOR() overflows in switch (int) #10650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29972cb
fix(ioctl): `FIONWRITE` overflows in `switch (int)`
Tang-Haojin Sep 1, 2025
2cefbe1
fixup! use `rt_device_t`
Tang-Haojin Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/drivers/ipc/pipe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ static int pipe_fops_ioctl(struct dfs_file *fd, int cmd, void *args)

pipe = (rt_pipe_t *)fd->vnode->data;

switch (cmd)
switch ((rt_ubase_t)cmd)
{
case FIONREAD:
*((int*)args) = rt_ringbuffer_data_len(pipe->fifo);
Expand Down
4 changes: 2 additions & 2 deletions components/drivers/serial/dev_serial.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ static int serial_fops_ioctl(struct dfs_file *fd, int cmd, void *args)
int mask = O_NONBLOCK | O_APPEND;

device = (rt_device_t)fd->vnode->data;
switch (cmd)
switch ((rt_ubase_t)cmd)
{
case FIONREAD:
break;
Expand Down Expand Up @@ -1074,7 +1074,7 @@ static rt_err_t rt_serial_control(struct rt_device *dev,
RT_ASSERT(dev != RT_NULL);
serial = (struct rt_serial_device *)dev;

switch (cmd)
switch ((rt_ubase_t)cmd)
{
case RT_DEVICE_CTRL_SUSPEND:
/* suspend device */
Expand Down
4 changes: 2 additions & 2 deletions components/drivers/serial/dev_serial_v2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ static int serial_fops_ioctl(struct dfs_file *fd, int cmd, void *args)
int mask = O_NONBLOCK | O_APPEND;

device = (rt_device_t)fd->vnode->data;
switch (cmd)
switch ((rt_ubase_t)cmd)
{
case FIONREAD:
break;
Expand Down Expand Up @@ -1385,7 +1385,7 @@ static rt_err_t rt_serial_control(struct rt_device *dev,
RT_ASSERT(dev != RT_NULL);
serial = (struct rt_serial_device *)dev;

switch (cmd)
switch ((rt_ubase_t)cmd)
{
case RT_DEVICE_CTRL_SUSPEND:
/* suspend device */
Expand Down