Skip to content

[bsp][gd32]: can add support for GD32F5xx #10737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

[bsp][gd32]: can add support for GD32F5xx #10737

merged 1 commit into from
Sep 25, 2025

Conversation

CYFS3
Copy link
Contributor

@CYFS3 CYFS3 commented Sep 24, 2025

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

PixPin_2025-09-24_21-26-13

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: GD32 BSP related with GD32 labels Sep 24, 2025
@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below.

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：gd32527_can_device
  • 设置PR number为 \ Set the PR number to：10737
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 gd32527_can_device 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the gd32527_can_device branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

kurisaW
kurisaW reviewed Sep 24, 2025
View reviewed changes
bsp/gd32/arm/libraries/gd32_drivers/drv_can.c
if (can_interrupt_flag_get(can_x, CAN_INT_FLAG_MTF0))
{
if (!can_interrupt_flag_get(can_x, CAN_FLAG_MTFNERR0))
if (!can_flag_get(can_x, CAN_FLAG_MTFNERR0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看GD这块针对中断留出的接口应该是can_interrupt_flag_get吧，为什么要改成can_flag_get呢

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PixPin_2025-09-24_21-38-24 zhe这边应该要获取的是CAN_TSTAT发送状态寄存器，而且这个interrupt_flag应该指的是CAN_INTEN这个寄存器吧，并非说中断的接口。如果使用原本的函数，应用层这边应该会一直认定他发送没有完成

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯呢，是这么个逻辑，可以这么修改

@kurisaW
Copy link
Member

kurisaW commented Sep 24, 2025

另外编码问题关注下：

image

@CYFS3
Copy link
Contributor Author

CYFS3 commented Sep 24, 2025

另外编码问题关注下：

image
PixPin_2025-09-24_21-42-18 我已经运行了工作流了，好像没有推送，

@kurisaW
Copy link
Member

kurisaW commented Sep 24, 2025

另外编码问题关注下：
image

PixPin_2025-09-24_21-42-18 我已经运行了工作流了，好像没有推送，

因为对于你运行的格式化CI来说，你执行的是clang-format工具，然后他确实正常运行了，但是没有检测出格式问题（我本地运行确实也没有检测出格式问题，但是脚本是正常可用的）

然后你这里看到报错的格式化CI走的应该并不是clang-format，所以你先根据他给的提示改一下吧，等后面这个CI和clang-format优化一下就合理了

@CYFS3 CYFS3 force-pushed the gd32527_can_device branch from 66d2ecd to 950166d Compare September 25, 2025 02:14
@CYFS3
Copy link
Contributor Author

CYFS3 commented Sep 25, 2025

另外编码问题关注下：
image

PixPin_2025-09-24_21-42-18 我已经运行了工作流了，好像没有推送，

因为对于你运行的格式化CI来说，你执行的是clang-format工具，然后他确实正常运行了，但是没有检测出格式问题（我本地运行确实也没有检测出格式问题，但是脚本是正常可用的）

然后你这里看到报错的格式化CI走的应该并不是clang-format，所以你先根据他给的提示改一下吧，等后面这个CI和clang-format优化一下就合理了

好的已经修改

@CYFS3 CYFS3 force-pushed the gd32527_can_device branch from 950166d to e3e5191 Compare September 25, 2025 02:49
kurisaW
kurisaW approved these changes Sep 25, 2025
View reviewed changes
bsp/gd32/arm/libraries/gd32_drivers/drv_can.c
if (can_interrupt_flag_get(can_x, CAN_INT_FLAG_MTF0))
{
if (!can_interrupt_flag_get(can_x, CAN_FLAG_MTFNERR0))
if (!can_flag_get(can_x, CAN_FLAG_MTFNERR0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯呢，是这么个逻辑，可以这么修改

@CYFS3
Copy link
Contributor Author

CYFS3 commented Sep 25, 2025

RT-Thread-packages/gd32-arm-series#6
需要合并这个pr

Rbb666
Rbb666 reviewed Sep 25, 2025
View reviewed changes
bsp/gd32/arm/libraries/gd32_drivers/drv_can.c Outdated
}

static int _can_sendmsg(struct rt_can_device *can, const void *buf, rt_uint32_t box_num)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除多余的换行吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除多余的换行吧

已经删除

@CYFS3 CYFS3 force-pushed the gd32527_can_device branch from e3e5191 to b6af2d6 Compare September 25, 2025 06:42
@CYFS3 CYFS3 force-pushed the gd32527_can_device branch from b6af2d6 to b740f3c Compare September 25, 2025 07:35
@kurisaW kurisaW merged commit 1daedb0 into RT-Thread:master Sep 25, 2025
41 checks passed
@CYFS3 CYFS3 deleted the gd32527_can_device branch September 29, 2025 12:43
@CYFS3 CYFS3 mentioned this pull request Oct 16, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Rbb666 left review comments

@supperthomas supperthomas supperthomas approved these changes

@kurisaW kurisaW kurisaW approved these changes

Assignees

No one assigned

Labels

BSP: GD32 BSP related with GD32 BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CYFS3 @kurisaW @supperthomas @Rbb666