Skip to content

fixes cppcheck: #10781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2025
Merged

fixes cppcheck: #10781

merged 1 commit into from
Oct 11, 2025

Conversation

@lygstate
Copy link
Contributor

@lygstate lygstate commented Oct 10, 2025

[cpp_check.py 80 INFO] bsp/w60x/drivers/drv_rtc.c:58:11: error: Syntax Error: AST broken, binary operator '&=' doesn't have two operands. [internalAstError]

[cpp_check.py 80 INFO] libcpu/arm/s3c24x0/rtc.c:34:12: error: Expression 'RTCCON|=RTCCON|=0x01' depends on order of evaluation of side effects [unknownEvaluationOrder]

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@lygstate
fixes cppcheck:
16b6bbe 
[cpp_check.py 80 INFO] bsp/w60x/drivers/drv_rtc.c:58:11: error: Syntax Error: AST broken, binary operator '&=' doesn't have two operands. [internalAstError]

[cpp_check.py 80 INFO] libcpu/arm/s3c24x0/rtc.c:34:12: error: Expression 'RTCCON|=RTCCON|=0x01' depends on order of evaluation of side effects [unknownEvaluationOrder]
@github-actions
Copy link

github-actions bot commented Oct 10, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：cppcheck_fixes
  • 设置PR number为 \ Set the PR number to：10781
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 cppcheck_fixes 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the cppcheck_fixes branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@supperthomas supperthomas requested a review from Copilot October 10, 2025 13:19
Copilot AI reviewed Oct 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes cppcheck static analysis errors by correcting syntax issues in RTC-related code across two files.

  • Fixes a double assignment operator issue in s3c24x0 RTC code that was causing AST evaluation errors
  • Replaces hardcoded bit masks with BIT() macro for better readability and consistency in w60x RTC driver

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
libcpu/arm/s3c24x0/rtc.c Removes incorrect double assignment and replaces with direct macro call
bsp/w60x/drivers/drv_rtc.c Replaces hardcoded bit shift operations with BIT() macro

libcpu/arm/s3c24x0/rtc.c

/* enable access to RTC registers */
RTCCON |= RTC_ENABLE;
RTC_ENABLE;
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug/错误: The line RTC_ENABLE; appears to be a standalone macro call that likely has no effect. Based on the original code RTCCON |= RTC_ENABLE;, this should probably be RTCCON |= RTC_ENABLE; to actually enable RTC access by setting the enable bit in the control register. / 单独的宏调用 RTC_ENABLE; 可能没有任何效果。根据原始代码 RTCCON |= RTC_ENABLE;，这应该是 RTCCON |= RTC_ENABLE; 来通过设置控制寄存器中的使能位来实际启用RTC访问。

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

@lygstate lygstate Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the AI is not smart enough, because

#define RTC_ENABLE      RTCCON |=  0x01;    /*RTC read and write enable */

supperthomas
supperthomas requested changes Oct 10, 2025
View reviewed changes
libcpu/arm/s3c24x0/rtc.c

/* enable access to RTC registers */
RTCCON |= RTC_ENABLE;
RTC_ENABLE;
Copy link
Member

@supperthomas supperthomas Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个和之前的逻辑有区别吧？

Copy link
Contributor Author

@lygstate lygstate Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有区别，这个代码有问题，正确用法也有参考

lygstate
lygstate commented Oct 10, 2025
View reviewed changes
libcpu/arm/s3c24x0/rtc.c
sec = BIN2BCD(ti->tm_sec);

/* enable access to RTC registers */
RTC_ENABLE
Copy link
Contributor Author

@lygstate lygstate Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是正确的用法， @Copilot, @supperthomas

@supperthomas supperthomas merged commit 5ae232b into RT-Thread:master Oct 11, 2025
55 checks passed
@supperthomas
Copy link
Member

supperthomas commented Oct 11, 2025

标题以后注意下

@lygstate
Copy link
Contributor Author

lygstate commented Oct 11, 2025

标题以后注意下

? 注意啥？

@lygstate lygstate deleted the cppcheck_fixes branch October 11, 2025 04:59
@supperthomas
Copy link
Member

supperthomas commented Oct 11, 2025

标题以后注意下

? 注意啥？

image

@lygstate
Copy link
Contributor Author

lygstate commented Oct 21, 2025

标题以后注意下

? 注意啥？

image

我的意思是标准是啥，标题应该改成啥样的比较合适

@supperthomas
Copy link
Member

supperthomas commented Oct 22, 2025

image

@lygstate
Copy link
Contributor Author

lygstate commented Oct 22, 2025

image

f好费劲，你可以直接把期望的标题文字打出来嘛，这些截图我看不懂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@supperthomas supperthomas supperthomas approved these changes

Assignees

No one assigned

Labels

BSP libcpu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lygstate @supperthomas