Skip to content

Conversation

@qgyhd1234
Copy link
Contributor

@qgyhd1234 qgyhd1234 commented Feb 21, 2019

拉取/合并请求描述:(PR description)

[
之前的 ymodem 在握手阶段,在接收到第一个数据为 SOH 或 STX 后,会立即读取后面的所有数据。而有些单片机的串口硬件 fifo 为 128,小于 ymodem 的一帧 133,会导致接受数据不全,ymodem 握手失败,直接退出。

已经在 CY8C6347BZI 和 stm32l475 上测试成功。
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other style
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

@qgyhd1234
Copy link
Contributor Author

@armink 这样改可以吗?

@qgyhd1234 qgyhd1234 force-pushed the ymodem branch 3 times, most recently from a9f1ea4 to 1f66674 Compare February 21, 2019 03:05
@qgyhd1234
Copy link
Contributor Author

@armink 修改完成

@armink armink changed the title [components][ymodem]ymodem 握手阶段增加延时,防止数据接收不全 [components][ymodem]ymodem 握手阶段增加超时重试,防止数据接收不全 Feb 23, 2019
@BernardXiong BernardXiong requested a review from armink February 23, 2019 13:44
@BernardXiong BernardXiong merged commit 4723d5d into RT-Thread:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants