[bsp/es32f0654]add spi/i2c drivers #2367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misonyo
reviewed
Feb 26, 2019
bsp/es32f0654/Kconfig
Outdated
|
|
||
| source "drivers/Kconfig" | ||
|
|
||
| if RT_USING_W25QXX || RT_USING_SFUD |
Contributor
There was a problem hiding this comment.
这里对于flash的选择项放到driver下面的kconfig里面，参考stm32，放到板载外设菜单类，使用宏BSP_USING_SPI_FLASH
bsp/es32f0654/drivers/drv_i2c.c
Outdated
| @@ -0,0 +1,142 @@ | |||
| /* | |||
| * File : drv_i2c.c | |||
bsp/es32f0654/drivers/drv_i2c.c
Outdated
| RT_NULL, | ||
| }; | ||
|
|
||
| int drv_i2c_init(void) |
Contributor
There was a problem hiding this comment.
这个函数改为rt_hw_i2c_init(),驱动函数初始化的命名统一加rt_hw_xxx_init()
bsp/es32f0654/drivers/drv_i2c.h
Outdated
| #ifndef DRV_I2C_H__ | ||
| #define DRV_I2C_H__ | ||
|
|
||
| int hw_i2c_init(void); |
bsp/es32f0654/drivers/drv_i2c.c
Outdated
| * File : drv_i2c.c | ||
| * Copyright (C) 2018 Shanghai Eastsoft Microelectronics Co., Ltd. | ||
| * | ||
| * description: I2C0_SCL->PB8, I2C0_SDA->PB9 |
Contributor
There was a problem hiding this comment.
多余的描述信息也不要放这里吧，可以放GPIO初始化的函数那里，作为注释。
bsp/es32f0654/drivers/drv_spi.c
Outdated
| * File : drv_spi.c | ||
| * Copyright (C) 2018 Shanghai Eastsoft Microelectronics Co., Ltd. | ||
| * | ||
| * description: SPI0_SCK->PB3, SPI0_MISO->PB4, SPI0_MOSI->PB5 |
bsp/es32f0654/drivers/drv_spiflash.h
Outdated
| #ifndef DRV_NOR_FLASH_H__ | ||
| #define DRV_NOR_FLASH_H__ | ||
|
|
||
| extern int rt_w25qxx_init(void); |
bsp/es32f0654/drivers/drv_spiflash.h
Outdated
| #define DRV_NOR_FLASH_H__ | ||
|
|
||
| extern int rt_w25qxx_init(void); | ||
| int rt_nor_flash_init(void) |
Contributor
There was a problem hiding this comment.
这个函数参考STM32命名为rt_hw_spi_flash_init()更合适？
bsp/es32f0654/drivers/drv_spiflash.c
Outdated
| es32f0_spi_bus_attach_device(RT_FLASH_CS_PIN, RT_FLASH_SPI_BUS_NAME, "spi00"); | ||
|
|
||
| #ifdef RT_USING_W25QXX | ||
| return w25qxx_init("flash0", "spi00"); |
Contributor
There was a problem hiding this comment.
参考stm32 BSP提供的FLASH移植文件，bsp\stm32\stm32f407-atk-explorer-fs-test\board\ports\spi_flash_init.c，probe的第一个函数的名称就取名为flash设备的信号，如W25Q128，w25qxx_init()应该是不需要调用的，然后这个函数和.h里面extern的名称有差别。SPI flash对应的宏判断为BSP_USING_SPI_FLASH。
misonyo
reviewed
Feb 28, 2019
bsp/es32f0654/drivers/SConscript
Outdated
| src += ['drv_i2c.c'] | ||
|
|
||
| # add w25qx flash driver code | ||
| if GetDepend('RT_USING_W25QXX') or GetDepend('RT_USING_SFUD'): |
Contributor
There was a problem hiding this comment.
这里判断BSP_USING_SPI_FLASH就好了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[ [bsp/es32f0654]add spi/i2c drivers ]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up