Fix dlmodule must depends on file system issue #3294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
解决dlmodule只能依赖于文件系统的问题;
增加dlmodule扩展接口，以适应更多需求;
|
|
rtthread-bot
requested changes
Dec 26, 2019
components/libc/libdl/dlmodule.c
Outdated
| return module; | ||
| } | ||
|
|
||
| struct rt_dlmodule* dlmodule_ext_load(const char* filename, struct rt_dlmodule_ops* ops) |
Member
There was a problem hiding this comment.
prefer as dlmodule_load_custom;
And please add setting in KConfig.
components/libc/libdl/dlmodule.c
Outdated
| return RT_NULL; | ||
| } | ||
|
|
||
| struct rt_dlmodule* dlmodule_ext_exec(const char* pgname, const char* cmd, int cmd_size, struct rt_dlmodule_ops* ops) |
解决dlmodule只能依赖于文件系统的问题;
增加dlmodule扩展接口，以适应更多需求;
rtthread-bot
requested changes
Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
解决dlmodule只能依赖于文件系统的问题，增加dlmodule扩展接口，以适应更多需求。
当产品不带文件系统，或者需要从外部设备（如SPI，UART，WIFI，蓝牙，共享内存，或其他协处理器等）加载动态模块时，当前接口无法满足需求。
为了不改变之前程序接口，在新增加的两个函数接口中引入“加载/释放”回调函数接口，可由外部程序根据需求灵活的修改“加载/释放”方式，以满足对不同应用场景的需求。
该问题已经在RK2108开发版上验证；
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up