Skip to content

Conversation

@supperthomas
Copy link
Member

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added the action github action yml imporve label Jan 10, 2025
@Rbb666 Rbb666 requested a review from unicornx January 10, 2025 02:46
@RT-Thread RT-Thread locked and limited conversation to collaborators Jan 10, 2025
@RT-Thread RT-Thread unlocked this conversation Jan 10, 2025
@supperthomas supperthomas reopened this Jan 10, 2025
@supperthomas
Copy link
Member Author

supperthomas commented Jan 11, 2025

@unicornx 汪老师这个你们继续完善吧,这个bsp我没有开发板,ci build可以帮助维护代码编译情况,对bsp也是有帮助的。

@unicornx
Copy link
Contributor

@unicornx 汪老师这个你们继续完善吧,这个bsp我没有开发板,ci build可以帮助维护代码编译情况,对bsp也是有帮助的。

好的,我已经新建了 #9795 但是一直没有找到时间做。我看看还能找到人来帮忙做一下。

这个 PR 先不要合并,duo 上分大小核,我看看是否要分多个 pr。

@github-actions github-actions bot added BSP BSP: Cvitek BSP related with cvitek labels Jan 21, 2025
@supperthomas supperthomas marked this pull request as ready for review January 21, 2025 01:30
@supperthomas
Copy link
Member Author

先合并吧。POST-BUILD 后面其他人再加一下,先注释掉。

@supperthomas supperthomas added the +1 Agree +1 label Jan 21, 2025
@BernardXiong BernardXiong merged commit 969e0e0 into master Jan 23, 2025
47 checks passed
@supperthomas supperthomas deleted the cvitek/c906_little branch January 23, 2025 01:35
@unicornx
Copy link
Contributor

先合并吧。POST-BUILD 后面其他人再加一下,先注释掉。

这是啥意思啊,这个注释了,对 duo 开发的人影响太大了吧,以前 scons 就能生成 fip.bin 的,现在完全要手动介入了?

为啥要做这个?我希望回退这个pr

unicornx added a commit to unicornx/rt-thread that referenced this pull request Jan 23, 2025
BernardXiong pushed a commit that referenced this pull request Jan 23, 2025
Revert "[action] add cvitek/c906_little ci (#9901)"

This reverts commit 969e0e0.
1078249029 pushed a commit to 1078249029/rt-thread that referenced this pull request Jan 23, 2025
* [action] add cvitek/c906_little ci

* Update bsp_buildings.yml

* Update rtconfig.py
1078249029 pushed a commit to 1078249029/rt-thread that referenced this pull request Jan 23, 2025
Revert "[action] add cvitek/c906_little ci (RT-Thread#9901)"

This reverts commit 969e0e0.
1078249029 pushed a commit to 1078249029/rt-thread that referenced this pull request Jan 24, 2025
* [action] add cvitek/c906_little ci

* Update bsp_buildings.yml

* Update rtconfig.py
1078249029 pushed a commit to 1078249029/rt-thread that referenced this pull request Jan 24, 2025
Revert "[action] add cvitek/c906_little ci (RT-Thread#9901)"

This reverts commit 969e0e0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve BSP: Cvitek BSP related with cvitek BSP +1 Agree +1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants