-
Notifications
You must be signed in to change notification settings - Fork 21
Add new options includeFiles #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options includeFiles #87
Conversation
add option.includeFiles add option.bethSymbol add tests to cover new features update Readme
|
These changes can help to close #77 issue. |
|
I'm not sure I understand how For gluing the prefix to the selector ( Since both the cases you presented are already covered by existing functionality then I'd avoid adding more params to the plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove bethSelector since it's covered by existing functionality.
That issue was referring to prefixing only certain selectors, not certain files so sadly it will remain open :( |
Yes, you right... I didn't pay enough attention |
|
Update PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks better but you need to solve the issue I mentioned with how includeFiles works and update the tests.
rem unused test add include tests
|
@RadValentin |
|
Looks good to me! 👍 Thanks for contributing, I'll release a new version of the plugin today. |
I hope all my changes will be clear.

Add tests for all new cases. All test is green
Feel free to write in any question.
PS: for me important to use an updated version in my project )