Updates FontAwesome to version 6 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #46 The TLDR is that this updates our FontAwesome v4 to FontAwesomePro v6, via Runtriz. (Thanks for the assist, Alonso!) The full methodology is detailed in Issue #46, but the short version is that I: 1) Identify all repos we have using radius-rails 2) Within those repos, grep for all fa-* class uses 3) Distill that down to a unique, sorted list 4) Determine which FA sets are needed to satisfy these classes This gave me a trivial list of files that were being used, but I suspected we could pare it down further. For each file, I reviewed whether or not the enabling class (eg. fad / fa-duotone) was being used anywhere in any of our apps that use radius-rails. Most of the collections were _not_ being used, so I could omit them. In the end we only had to include the basic set, fa-regular, fa-brands, and fa-solid. I also incorporated the v4-shims fontface and styles to give us backwards compatibility - there were a couple styles (fa-empire, used on "New Order" nav link) that have been changed since v4. The old font-awesome files have been deleted. Note that there are fewer variations now than there used to be (just WOFF2 and TTF). Additionally, as this is significant version bump in one of the major dependencies, I did a major version bump for the gem 3.x -> 4.0.
This is the most current version in the 3.x series. It corrects some bugs and adds slightly newer versions of some dependencies: https://github.com/twbs/bootstrap/releases/tag/v3.3.7 Additionally, I added glyphicons to the font list because it's used by Bootstrap and didn't appear to be available previously.
…lasses, cleans up stylesheets slightly
Contributor
|
It should be noted that |
jcavena
approved these changes
Oct 15, 2025
Contributor
jcavena
left a comment
jcavena
left a comment
There was a problem hiding this comment.
Tested locally and the glyphs looked good! We did figure out that "Source Sans Pro" is blocked locally as it's a google font and local dev defaults to Helvetica.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46
The TLDR is that this updates our FontAwesome v4 to FontAwesomePro v6, via Runtriz. (Thanks for the assist, Alonso!)
The full methodology is detailed in Issue #46, but the short version is that I:
This gave me a trivial list of files that were being used, but I suspected we could pare it down further. For each file, I reviewed whether or not the enabling class (eg. fad / fa-duotone) was being used anywhere in any of our apps that use radius-rails. Most of the collections were not being used, so I could omit them.
In the end we only had to include the basic set, fa-regular, fa-brands, and fa-solid.
I also incorporated the v4-shims fontface and styles to give us backwards compatibility - there were a couple styles (fa-empire, used on "New Order" nav link) that have been changed since v4.
The old font-awesome files have been deleted. Note that there are fewer variations now than there used to be (just WOFF2 and TTF).
Additionally, as this is significant version bump in one of the major dependencies, I did a major version bump for the gem 3.x -> 4.0.
QA Steps
Gemfileof your favoriteradius-railsusing appradius-railsgem line look like this:gem "radius-rails", path: "../radius-rails"bundle installPost-Merge steps
Referring to our gem deployment docs