Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • fix bug with calculating unity 6.0 and 6.3 lts fallback versions
  • added additional unit tests

- fix bug with calculating unity 6.0 and 6.3 lts fallback versions
- added additional unit tests
Copilot AI review requested due to automatic review settings December 7, 2025 16:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in Unity version resolution for 6.0 and 6.3 LTS releases and adds comprehensive test coverage for version matching logic.

  • Removed incorrect fallback logic that would search for any minor version when minor === 0 had no candidates
  • Added five new unit tests covering various version matching scenarios
  • Updated dependencies (yaml, ts-jest) and transitive dependencies

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/unity-version.ts Removed problematic fallback logic that incorrectly matched different minor versions when requesting x.0.x patterns
tests/unity-version.test.ts Added comprehensive test cases covering major-only versions, wildcards, channel preferences, and explicit minor version handling
package.json Bumped version to 1.8.0 and updated yaml (2.8.1→2.8.2) and ts-jest (29.4.5→29.4.6) dependencies
package-lock.json Updated lockfile to reflect package.json changes and transitive dependency updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StephenHodgson StephenHodgson merged commit f36f87f into main Dec 7, 2025
144 of 145 checks passed
@StephenHodgson StephenHodgson deleted the development branch December 7, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant