Update some peripherals for Atmega128rfa1 #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe we can update to the rust version of svdtools (#174)? |
Owner
|
Just for clarification: Do these changes depend on #174 or are they independent in their current form? |
Contributor
Author
|
I just checked it out and it doesn't depend on changes in #174 and also works with svdtools 0.4.0. |
Rahix
approved these changes
Jan 6, 2025
Owner
Rahix
left a comment
Rahix
left a comment
There was a problem hiding this comment.
Alright, thanks a lot for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
timer/atmega128rfa1.yaml"_replace_enum" fromtimer/dev/*.yamlapplies only for first COM* definition (svdtools 0.1.27) so I added it manually. I don't know what the reason but patch works correctly without manual definitions with svdtools 0.3.20 installed from cargo.