Skip to content
This repository was archived by the owner on Nov 4, 2024. It is now read-only.

Conversation

@Alphix
Copy link

@Alphix Alphix commented Jan 31, 2018

I'm not a PHP guru but it seems that the switch statement would always
just go with the default.

I'm not a PHP guru but it seems that the switch statement would always
just go with the default.
@Alphix
Copy link
Author

Alphix commented Jan 31, 2018

See issue #1576

@Alphix Alphix mentioned this pull request Jan 31, 2018
@Alphix
Copy link
Author

Alphix commented Jan 31, 2018

Update: seems I was wrong about the switch statement being incorrect (see #1576).

I still think my alternative is much cleaner though, so I'll leave this PR open and let the maintainers decide whether they agree or not.

@RainLoop
Copy link
Owner

Hi @Alphix .
Unfortunately, your code isn't the same as mine. It doesn't work correctly for some reasons.
For example, in your case if fast_cache_driver = 'acp', but apc_store function doesn't exist, then $oDriver stay null. It's a bug, because my code supports failback to the FILES driver.

@RainLoop RainLoop closed this Mar 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants