Rake task for the archery project #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject' of https://github.com/RaspberryPiFoundation/choco-cake into issues/10-Rake_task_for_the_archery_project
ArayB
suggested changes
Feb 11, 2022
Contributor
ArayB
left a comment
ArayB
left a comment
There was a problem hiding this comment.
Couple of little things to amend.
I'm actually thinking now that maybe we could make more use of the metadata file. The file could define the components and their index to mean less munging of data in the rake task.
Maybe switching that config file to be json and using hashes and arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10