Skip to content

Refactor routing to remove phrases part of URL #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 7, 2022
Merged

Refactor routing to remove phrases part of URL #26

merged 6 commits into from
Mar 7, 2022

Conversation

@create-issue-branch
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Mar 4, 2022 •
edited by ArayB
Loading

  • Removes phrases from routes.
  • Moves actions from phrases_controller to projects_controller
  • Removes phrases_controller
  • Adds request specs
  • Adds CanCanCan for authorising resources
  • Adds bundle volume to docker-compose so gems can be added without needing to rebuild container.

closes #25

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Mar 4, 2022

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Mar 4, 2022

@ArayB ArayB mentioned this pull request Mar 4, 2022
Closed
@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Mar 4, 2022

@raspberrypigithubbot
Copy link

raspberrypigithubbot commented Mar 4, 2022

@ArayB ArayB marked this pull request as ready for review March 4, 2022 16:07
loiswells97
loiswells97 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, although would appreciate a huddle at some point next week to go through the CanCanCan stuff if possible?

@ArayB ArayB merged commit 27d476c into main Mar 7, 2022
@ArayB ArayB deleted the issues/25-Refactor_routing_to_remove_phrases_part_of_URL branch March 7, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loiswells97 loiswells97 loiswells97 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor routing to remove phrases part of URL

4 participants

@raspberrypigithubbot @loiswells97 @ArayB