Add properties to existing responses #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raspberrypiherokubot
temporarily deployed
to
editor-api-p-add-proper-itbt52
sra405
changed the title
loiswells97
reviewed
Jul 25, 2024
Comment on lines
+20
to
+26
| if lesson.project | ||
| json.project( | ||
| lesson.project, | ||
| :identifier, | ||
| :project_type | ||
| ) | ||
| end |
Contributor
There was a problem hiding this comment.
Could we add a test for this? No worries though if it's going to get complex 😅
loiswells97
approved these changes
Jul 25, 2024
Contributor
loiswells97
left a comment
loiswells97
left a comment
There was a problem hiding this comment.
Looks great, let's get it out there! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
codehas been added to the school show response for the dashboardprojecthas been added to the lesson index so we can direct students to the project from the class page