Skip to content

Conversation

@patch0
Copy link
Contributor

@patch0 patch0 commented Oct 31, 2022

closes #73

Adds exception handling to the API to enable errors to be logged into Sentry.

There was a general rubocop clean-up, and this has updated the tests (mostly).

I've added a noddy test to the create operation, to ensure that Sentry is called correctly. I've not added similar tests to the remix and update services.

This needs a Terraform PR to complete deployment.

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-sentry-agemmb October 31, 2022 12:41 Inactive
@raspberrypigithubbot
Copy link

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-sentry-jh0mdf October 31, 2022 13:25 Inactive
@raspberrypigithubbot
Copy link

@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-sentry-b7bx2u October 31, 2022 13:50 Inactive
@raspberrypigithubbot
Copy link

@patch0 patch0 requested a review from loiswells97 October 31, 2022 15:09
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to editor-api-p-add-sentry-8qtrow October 31, 2022 15:28 Inactive
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@raspberrypigithubbot
Copy link

@patch0 patch0 enabled auto-merge October 31, 2022 15:28
@patch0 patch0 merged commit afef9bd into main Oct 31, 2022
@patch0 patch0 deleted the add-sentry branch October 31, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception handling API and Sentry

5 participants