Modify abilities to prevent link sharing #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raspberrypiherokubot
temporarily deployed
to
editor-api-p-issues-89--xayl0g
raspberrypiherokubot
temporarily deployed
to
editor-api-p-issues-89--qragio
patch0
reviewed
Dec 5, 2022
| it 'returns forbidden response' do | ||
| get "/api/projects/#{another_project.identifier}" | ||
|
|
||
| expect(response).to have_http_status(:forbidden) |
Contributor
There was a problem hiding this comment.
I think I'd rather this was :not_found (no immediate information leakage about whether a project exists)
Timing attacks would still give it away though, as less work is (probably) being done if no project is found.
Happy for this to be pushed into a new issue.
Contributor
There was a problem hiding this comment.
Interestingly, we now have separate design for these two cases, so maybe this is part of a wider discussion...
patch0
approved these changes
Dec 5, 2022
Contributor
patch0
left a comment
patch0
left a comment
There was a problem hiding this comment.
Comment about forbidden vs not found, but happy to merge
loiswells97
deleted the
issues/89-Modify_abilities_to_prevent_link_sharing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?
abilityfile to allow users to only read projects with nouser_id(i.e. RPF starter/example projects) and projects owned by the userability_spectestsshow_spectests to reflect the above changesimage_listcloses #89