Update EditorPanel to honour font size changes #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch0
temporarily deployed
to
previews/1277/merge
GitHub Actions
Inactive
Copilot finished reviewing on behalf of
patch0
November 18, 2025 17:54
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where font size changes were not taking effect in the EditorPanel due to a typography.style-1() mixin being applied to the .cm-scroller class. The changes migrate the styling to use Design System typography styles consistently.
- Removes the problematic
typography.style-1()from.cm-scrollerthat was preventing font size changes - Migrates from local SCSS font-size mixins to Design System typography mixins for size modifiers
- Replaces SCSS spacing variables with CSS custom properties for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patch0
added a commit
that referenced
this pull request
Nov 18, 2025
## [0.34.1] - 2025-11-18 ### Fixed - Font size selection now works in the web component (#1277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1264 we added a
typography.style-1()to the.cm-scrollerclass in the EditorPanel css, which unwittingly prevented font sizes from taking effect.This PR reverts that, but also tidies up the styling to use Design System typography styles instead, so line spacing etc goes with it.
Also removes the
$space-0-5var in favour of the Design System vars.e.g.
Small:
Medium:
Large:
