Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message notifications for how to make this project your own #291

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Dec 5, 2022

What's Changed?

  • Added login/save prompt messages that are shown after the first change when the user is not logged in/does not own project
  • Testing for the above
  • Reinstated some autosave tests in Project.test.js that were removed from App.test.js when the autosave trigger was moved

Screenshots

Screenshot 2022-12-16 at 14 16 32

Screenshot 2022-12-16 at 14 16 05

closes #286

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/286-Message_notifications_for_how_to_make_this_project_your_own December 5, 2022 10:58 Inactive
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/286-Message_notifications_for_how_to_make_this_project_your_own December 16, 2022 09:45 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/286-Message_notifications_for_how_to_make_this_project_your_own December 16, 2022 13:06 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/286-Message_notifications_for_how_to_make_this_project_your_own December 16, 2022 13:08 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 marked this pull request as ready for review December 16, 2022 14:11
@github-actions
Copy link

Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loiswells97 loiswells97 merged commit 959306a into main Dec 19, 2022
@loiswells97 loiswells97 deleted the issues/286-Message_notifications_for_how_to_make_this_project_your_own branch December 19, 2022 16:45
@patch0 patch0 mentioned this pull request Jan 6, 2023
patch0 added a commit that referenced this pull request Jan 6, 2023
### Added

- Plausbile event tracking for login, remix, save and code run (#250)
- Message prompting users to login or save if they make non-autosaved
changes (#291)
- Unit tests for the autosave trigger (#291)
- Project not found and access denied modals shown on project loading
error (#298)
- Styling for small buttons (#303)
- Project page header and styling (#314)
- Ability to open and focus files from the left hand file pane (#301)
- Ability to close file tabs (#301)
- Validation to prevent file names containing spaces (#301)

## Changed

- Bump terser from 4.8.0 to 4.8.1 (#143)
- Updated buttons and tabs styling (#296)
- Updated icons (#296)
- Bump engine.io from 6.2.0 to 6.2.1 (#272)
- Increased clickable area for tabs (#299)
- Bump decode-uri-component from 0.2.0 to 0.2.2 (#295)
- File tab bar scrolls rather than wraps (#301)
- Long file names no longer wrap in tab bar (#301)

### Fixed

- Moved `FileMenu` click handler to `MenuItem` for better keyboard
support (#300)
- Touch target size on button to open file context menu (#301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message notifications for how to make this project your own
2 participants