Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small buttons #303

Merged
merged 11 commits into from
Dec 22, 2022
Merged

Small buttons #303

merged 11 commits into from
Dec 22, 2022

Conversation

IzzySmillie
Copy link
Contributor

@IzzySmillie IzzySmillie commented Dec 22, 2022

  • Refactors the button component to accept a buttonOuter prop
  • Removed the theme from the NewComponentButton as pulls styles from the app class
  • Styling for the small button, with larger hit area

To use the btn--small in the future just need to pass the buttonOuter to the Button and btn--small class


Video as no review app:

Screen.Recording.2022-12-22.at.15.13.38.mov

@github-actions
Copy link

@IzzySmillie IzzySmillie changed the title Start skinny button rejig Skinny buttons Dec 22, 2022
@IzzySmillie IzzySmillie temporarily deployed to previews/skinny-buttons December 22, 2022 11:39 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/skinny-buttons December 22, 2022 12:04 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/skinny-buttons December 22, 2022 12:06 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/skinny-buttons December 22, 2022 12:20 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie self-assigned this Dec 22, 2022
@IzzySmillie IzzySmillie temporarily deployed to previews/skinny-buttons December 22, 2022 13:19 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/skinny-buttons December 22, 2022 15:08 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie changed the title Skinny buttons Small buttons Dec 22, 2022
@IzzySmillie IzzySmillie temporarily deployed to previews/skinny-buttons December 22, 2022 15:25 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie merged commit 6618416 into main Dec 22, 2022
@IzzySmillie IzzySmillie deleted the skinny-buttons branch December 22, 2022 15:49
@patch0 patch0 mentioned this pull request Jan 6, 2023
patch0 added a commit that referenced this pull request Jan 6, 2023
### Added

- Plausbile event tracking for login, remix, save and code run (#250)
- Message prompting users to login or save if they make non-autosaved
changes (#291)
- Unit tests for the autosave trigger (#291)
- Project not found and access denied modals shown on project loading
error (#298)
- Styling for small buttons (#303)
- Project page header and styling (#314)
- Ability to open and focus files from the left hand file pane (#301)
- Ability to close file tabs (#301)
- Validation to prevent file names containing spaces (#301)

## Changed

- Bump terser from 4.8.0 to 4.8.1 (#143)
- Updated buttons and tabs styling (#296)
- Updated icons (#296)
- Bump engine.io from 6.2.0 to 6.2.1 (#272)
- Increased clickable area for tabs (#299)
- Bump decode-uri-component from 0.2.0 to 0.2.2 (#295)
- File tab bar scrolls rather than wraps (#301)
- Long file names no longer wrap in tab bar (#301)

### Fixed

- Moved `FileMenu` click handler to `MenuItem` for better keyboard
support (#300)
- Touch target size on button to open file context menu (#301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants