Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close and open file tabs #301

Merged
merged 30 commits into from
Jan 6, 2023
Merged

Close and open file tabs #301

merged 30 commits into from
Jan 6, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Dec 16, 2022 •
edited by loiswells97
Loading

What's Changed?

  • File tab bar scrolls rather than wraps
  • File names no longer wrap in the tab bar, including stopping file names from containing spaces
  • Open and focus files from the left hand file pane including auto-scroll to the relevant file when it is focussed
  • Ability to close files
  • Increased touch target size on the file context menu button

closes #289

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/289-Close_and_open_file_tabs December 16, 2022 14:25 Inactive
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs December 19, 2022 12:28 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs December 19, 2022 15:21 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs December 20, 2022 14:55 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs December 23, 2022 09:48 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs December 23, 2022 09:49 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs January 4, 2023 17:04 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs January 4, 2023 17:27 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

@loiswells97 loiswells97 marked this pull request as ready for review January 4, 2023 17:32
@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs January 4, 2023 17:32 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

IzzySmillie
IzzySmillie reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a downward scroll on the menu bar bit now which I don't think should be there:

Screenshot 2023-01-05 at 10 35 50

Made a few (nit-picky!) comments and have looked over the code and seems all good to me. My reducer knowledge is rusted to dust so will let Patrick look over it before approving :)

src/components/Editor/EditorSlice.js Outdated Show resolved Hide resolved
src/components/FilePane/FilePane.test.js Outdated Show resolved Hide resolved
@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs January 5, 2023 12:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/289-Close_and_open_file_tabs January 5, 2023 15:46 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

patch0
patch0 approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@patch0 patch0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@loiswells97 loiswells97 merged commit 4558971 into main Jan 6, 2023
@loiswells97 loiswells97 deleted the issues/289-Close_and_open_file_tabs branch January 6, 2023 09:34
@patch0 patch0 mentioned this pull request Jan 6, 2023
Merged
patch0 added a commit that referenced this pull request Jan 6, 2023
@patch0
Release v0.10.0 (#320)
1153a99 
### Added

- Plausbile event tracking for login, remix, save and code run (#250)
- Message prompting users to login or save if they make non-autosaved
changes (#291)
- Unit tests for the autosave trigger (#291)
- Project not found and access denied modals shown on project loading
error (#298)
- Styling for small buttons (#303)
- Project page header and styling (#314)
- Ability to open and focus files from the left hand file pane (#301)
- Ability to close file tabs (#301)
- Validation to prevent file names containing spaces (#301)

## Changed

- Bump terser from 4.8.0 to 4.8.1 (#143)
- Updated buttons and tabs styling (#296)
- Updated icons (#296)
- Bump engine.io from 6.2.0 to 6.2.1 (#272)
- Increased clickable area for tabs (#299)
- Bump decode-uri-component from 0.2.0 to 0.2.2 (#295)
- File tab bar scrolls rather than wraps (#301)
- Long file names no longer wrap in tab bar (#301)

### Fixed

- Moved `FileMenu` click handler to `MenuItem` for better keyboard
support (#300)
- Touch target size on button to open file context menu (#301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IzzySmillie IzzySmillie IzzySmillie left review comments

@patch0 patch0 patch0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Close and open file tabs
3 participants
@patch0 @IzzySmillie @loiswells97