-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects page header #314
Merged
Merged
Projects page header #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
create-issue-branch
bot
commented
Jan 4, 2023
•
edited by IzzySmillie
Loading
edited by IzzySmillie
- closes Projects page header #307
- Small responsive fixes to footer so it doesn't completely break
- Typography file for H1, H2 and H3
- Mixins for device widths
create-issue-branch
bot
temporarily deployed
to
previews/issues/307-Projects_page_header
January 4, 2023 14:28
Inactive
|
|
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 4, 2023 15:41
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 4, 2023 16:10
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 4, 2023 16:28
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 4, 2023 17:11
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 4, 2023 17:26
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 5, 2023 09:37
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 5, 2023 09:50
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 5, 2023 10:21
— with
GitHub Actions
Inactive
|
loiswells97
requested changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few super picky comments, but apart from that looks good to me 👍
IzzySmillie
temporarily deployed
to
previews/issues/307-Projects_page_header
January 5, 2023 14:05
— with
GitHub Actions
Inactive
|
|
loiswells97
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Merged
patch0
added a commit
that referenced
this pull request
Jan 6, 2023
### Added - Plausbile event tracking for login, remix, save and code run (#250) - Message prompting users to login or save if they make non-autosaved changes (#291) - Unit tests for the autosave trigger (#291) - Project not found and access denied modals shown on project loading error (#298) - Styling for small buttons (#303) - Project page header and styling (#314) - Ability to open and focus files from the left hand file pane (#301) - Ability to close file tabs (#301) - Validation to prevent file names containing spaces (#301) ## Changed - Bump terser from 4.8.0 to 4.8.1 (#143) - Updated buttons and tabs styling (#296) - Updated icons (#296) - Bump engine.io from 6.2.0 to 6.2.1 (#272) - Increased clickable area for tabs (#299) - Bump decode-uri-component from 0.2.0 to 0.2.2 (#295) - File tab bar scrolls rather than wraps (#301) - Long file names no longer wrap in tab bar (#301) ### Fixed - Moved `FileMenu` click handler to `MenuItem` for better keyboard support (#300) - Touch target size on button to open file context menu (#301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.