Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update button and tab active or inactive for both colour modes #296

Merged
merged 56 commits into from
Dec 21, 2022
Merged

Update button and tab active or inactive for both colour modes #296

merged 56 commits into from
Dec 21, 2022

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Dec 8, 2022 •
edited by IzzySmillie
Loading

Screenshots
Screenshot 2022-12-14 at 09 09 16
Screenshot 2022-12-14 at 09 09 25

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 8, 2022 12:20 Inactive
@IzzySmillie IzzySmillie mentioned this pull request Dec 8, 2022
Closed
@IzzySmillie IzzySmillie self-assigned this Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 8, 2022 15:08 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 8, 2022 15:29 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 8, 2022 16:28 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 8, 2022 17:00 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 8, 2022 17:39 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 21, 2022 15:42 — with GitHub Actions Inactive
@github-actions
Copy link

@loiswells97
Copy link
Contributor

  • I did the darkmode buttons according to this figma link which had them as #4A4D59 which matches. That is with the icons though 🤔

Will check the others :)

  • Left border issue fixed in: d53d786
  • Projects link (and fix to title input) fixed in 068665e
  • Icon adjustment done in 6c92e06

Wonderful, thanks for these updates :) I was looking at this link but I guess given the inconsistency, let's just go with what you've done on this and see what design say

loiswells97
loiswells97 requested changes Dec 21, 2022
View reviewed changes
src/Modal.scss Outdated Show resolved Hide resolved
src/colours.scss Show resolved Hide resolved
src/components/BetaBanner/BetaBanner.scss Show resolved Hide resolved
src/components/Editor/FontSizeSelector/FontSizeSelector.scss Outdated Show resolved Hide resolved
src/components/Editor/FontSizeSelector/FontSizeSelector.scss Outdated Show resolved Hide resolved
src/components/Editor/FontSizeSelector/FontSizeSelector.scss Outdated Show resolved Hide resolved
src/hooks/useUserFont.js Outdated Show resolved Hide resolved
src/components/Button/Button.scss Outdated Show resolved Hide resolved
@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 21, 2022 16:26 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 21, 2022 16:31 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 21, 2022 16:42 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 21, 2022 16:47 — with GitHub Actions Inactive
@github-actions
Copy link

@IzzySmillie IzzySmillie temporarily deployed to previews/issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes December 21, 2022 16:52 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

loiswells97
loiswells97 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@IzzySmillie IzzySmillie merged commit 8a5bb31 into main Dec 21, 2022
@IzzySmillie IzzySmillie deleted the issues/274-Update_button_and_tab_active_or_inactive_for_both_colour_modes branch December 21, 2022 17:28
@patch0 patch0 mentioned this pull request Jan 6, 2023
Merged
patch0 added a commit that referenced this pull request Jan 6, 2023
@patch0
Release v0.10.0 (#320)
1153a99 
### Added

- Plausbile event tracking for login, remix, save and code run (#250)
- Message prompting users to login or save if they make non-autosaved
changes (#291)
- Unit tests for the autosave trigger (#291)
- Project not found and access denied modals shown on project loading
error (#298)
- Styling for small buttons (#303)
- Project page header and styling (#314)
- Ability to open and focus files from the left hand file pane (#301)
- Ability to close file tabs (#301)
- Validation to prevent file names containing spaces (#301)

## Changed

- Bump terser from 4.8.0 to 4.8.1 (#143)
- Updated buttons and tabs styling (#296)
- Updated icons (#296)
- Bump engine.io from 6.2.0 to 6.2.1 (#272)
- Increased clickable area for tabs (#299)
- Bump decode-uri-component from 0.2.0 to 0.2.2 (#295)
- File tab bar scrolls rather than wraps (#301)
- Long file names no longer wrap in tab bar (#301)

### Fixed

- Moved `FileMenu` click handler to `MenuItem` for better keyboard
support (#300)
- Touch target size on button to open file context menu (#301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IzzySmillie IzzySmillie IzzySmillie left review comments

@loiswells97 loiswells97 loiswells97 approved these changes

Assignees

@IzzySmillie IzzySmillie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update button and tab active or inactive for both colour modes
2 participants
@IzzySmillie @loiswells97