blink and pulse #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated RGBLED to support blink, pulse and colour cycles, all supporting multiple colours and timings
Prototype trying a generator (just for RGBLED to see if we like it)
Changed so use single instance of AsyncValueChange (avoiding some reentrancy issues when calling from an interrupt). Also used micropython.schedule to further reduce potential reentrancy/memory allocation issues. May need to do more but seems be callable from interrupts in simple scenarios. Should probably just set simple variables on the class during the interrupt.
Added more interesting defaults for RGB blink and pulse
Set generator to None on stop.
Fixes to get RGBLED working. Still issues with wait=False.
Removed override of off and minor updates to RGBLED
Changed ValueChange to set the timer to None and check for it before init. This seems to fix the issue where previous sequences could still be running (for LED and RGBLED) but not clear why this should be necessary.
martinohanlon
pushed a commit
that referenced
this pull request
Jan 3, 2023
Sync comment default for pull_up with code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.