Skip to content

Fix tool call argument serialization issue #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2025
Merged

Fix tool call argument serialization issue #39

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
119c857
Tool calling arguments JSON fix
phawrylak Sep 20, 2025
dcc60a7
Extracted duplicated code to helper function
phawrylak Sep 20, 2025
4f7b87f
Update utils.py
RayBytes Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions chatmock/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,30 @@ def sse_translate_chat(
ws_index: dict[str, int] = {}
ws_next_index: int = 0

def _serialize_tool_args(eff_args: Any) -> str:
"""
Serialize tool call arguments with proper JSON handling.

Args:
eff_args: Arguments to serialize (dict, list, str, or other)

Returns:
JSON string representation of the arguments
"""
if isinstance(eff_args, (dict, list)):
return json.dumps(eff_args)
elif isinstance(eff_args, str):
try:
parsed = json.loads(eff_args)
if isinstance(parsed, (dict, list)):
return json.dumps(parsed)
else:
return json.dumps({"query": eff_args})
except (json.JSONDecodeError, ValueError):
return json.dumps({"query": eff_args})
else:
return "{}"

def _extract_usage(evt: Dict[str, Any]) -> Dict[str, int] | None:
try:
usage = (evt.get("response") or {}).get("usage")
Expand Down Expand Up @@ -320,12 +344,7 @@ def _merge_from(src):
except Exception:
pass
eff_params = ws_state.get(call_id, params if isinstance(params, (dict, list, str)) else {})
if isinstance(eff_params, (dict, list)):
args_str = json.dumps(eff_params)
elif isinstance(eff_params, str):
args_str = json.dumps({"query": eff_params})
else:
args_str = "{}"
args_str = _serialize_tool_args(eff_params)
if call_id not in ws_index:
ws_index[call_id] = ws_next_index
ws_next_index += 1
Expand Down Expand Up @@ -402,12 +421,7 @@ def _merge_from(src):
pass
eff_args = ws_state.get(call_id, raw_args if isinstance(raw_args, (dict, list, str)) else {})
try:
if isinstance(eff_args, (dict, list)):
args = json.dumps(eff_args)
elif isinstance(eff_args, str):
args = json.dumps({"query": eff_args})
else:
args = "{}"
args = _serialize_tool_args(eff_args)
except Exception:
args = "{}"
if item.get("type") == "web_search_call" and verbose and vlog:
Expand Down