feat: improve compatiblity with certain apps #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uvx --from (...) chatmock should just work !
Magniquick
changed the title
Owner
|
Hey thanks for this PR. What do current apps work like without these changes? Currently out so may not be able to take a look at this soon, but will likely merge in the next couple of days |
Contributor
Author
|
Copliot just refuses to work without the /version edpoint, and throws warnings on the chat interface without the stop chunk. this just works with the copilot ollama endpoint - works well for jupyter notebooks and similar. |
Owner
|
LGTM! Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain apps (see the branch name ;) ) require stop chunk and the /api/version endpoint to work well - added them.
this commit also has #70 in it, so I reccomend merging that one first (or at least letting me know if you want any changes there)
also added subjectively better logging setup while debugging, feel free to cherry pick the others.
TODO: move the system prompt into the devloper role instead, tho that should prolly be another pr.