Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should include the <cfloat> header file by default #1161

Closed
eddelbuettel opened this issue May 8, 2021 · 0 comments
Closed

We should include the <cfloat> header file by default #1161

eddelbuettel opened this issue May 8, 2021 · 0 comments

Comments

@eddelbuettel
Copy link
Member

One thing became apparent during the work on #1158 for STRICT_R_HEADERS: a majority of patches / PRs simply require an #include of float.h (or, equivalently, cfloat).

Is there any reason we should not add that to RcppCommon.h?

We already include <limits> which, as I re-learned, only covers integer limits to <cfloat> would make sense.
@eddelbuettel eddelbuettel mentioned this issue May 9, 2021
Merged
4 tasks
eddelbuettel added a commit that referenced this issue May 13, 2021
@eddelbuettel
Merge pull request #1162 from RcppCore/feature/cfloat_header
c172a06 
add cfloat header (fixes #1161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eddelbuettel