Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinyformat refresher #356

Closed
eddelbuettel opened this issue Aug 29, 2015 · 4 comments
Closed

tinyformat refresher #356

eddelbuettel opened this issue Aug 29, 2015 · 4 comments

Comments

@eddelbuettel
Copy link
Member

It would appear that tinyformat got updated so we may want to take a look. Judging from git blame it is mostly one import followed by several surgical operations / insertions. Sounds about right to you, @kevinushey ?

@kevinushey
Copy link
Contributor

Yeah, seems like the update just includes fixes / workarounds for various compilers + warnings. Should be okay to bring in, although it may not help fix the issue at #354.

@eddelbuettel
Copy link
Member Author

Agree after a initial M-x ediff round. Do you want to merge it in, or should I do it?

@kevinushey
Copy link
Contributor

I'll let you do the honors ;) I'm currently trying to see if I can build R with ASAN and replicate #354 locally.

@eddelbuettel
Copy link
Member Author

Ahh. You are ahead of me on that front -- but I surely need your help and insights with tinyformat and stop() and that whole nexus. #354 looks weird -- tickle ASAN from a constant string? But it is a very well prepared ticket ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants