You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm preparing a PR that includes sugar counterparts for cumprod, cummin, and cummax in base R, along with the respective unit tests. I don't believe this will affect any existing code, and my unit tests & Travis build ran without hitch, but I wanted to open this issue for the sake of questions, concerns, or general discussion.
Briefly,
Rcpp::cumprod is templated for INTSXP, REALSXP, and CPLXSXP; and Rcpp::cummin & Rcpp::cummax are templated for INTSXP and REALSXP; in accordance with base::cumprod, base::cummin, and base::cummax, respectively
All three appear to handle NAs and matrix arguments correctly (re: in the same manner as base R)
The text was updated successfully, but these errors were encountered:
On the bright side, I wasn't docked any points for submitting on Read Only Friday : ). But noted - I will space things out more appropriately in the future, and thank you for the quick response,
I'm preparing a PR that includes
sugar
counterparts forcumprod
,cummin
, andcummax
in base R, along with the respective unit tests. I don't believe this will affect any existing code, and my unit tests & Travis build ran without hitch, but I wanted to open this issue for the sake of questions, concerns, or general discussion.Briefly,
Rcpp::cumprod
is templated forINTSXP
,REALSXP
, andCPLXSXP
; andRcpp::cummin
&Rcpp::cummax
are templated forINTSXP
andREALSXP
; in accordance withbase::cumprod
,base::cummin
, andbase::cummax
, respectivelyNA
s andmatrix
arguments correctly (re: in the same manner as base R)The text was updated successfully, but these errors were encountered: