Noisy installations of Rcpp 1.0.1 due to changes in RcppExports.cpp

[eddelbuettel]

[...]
/usr/local/lib/R-devel/lib/R/library/Rcpp/include/Rcpp/macros/macros.h:36:17: warning: unused variable ‘stop_sym’ [-Wunused-variable]
     static SEXP stop_sym = Rf_install("stop");                                                   \
                 ^~~~~~~~
/usr/local/lib/R-devel/lib/R/library/Rcpp/include/Rcpp/macros/macros.h:36:17: note: in definition of macro ‘BEGIN_RCPP’
     static SEXP stop_sym = Rf_install("stop");                                                   \
                 ^~~~~~~~
RcppExports.cpp: In function ‘SEXPREC* _RQuantLib_europeanOptionArraysEngine_try(SEXP, SEXP)’:
/usr/local/lib/R-devel/lib/R/library/Rcpp/include/Rcpp/macros/macros.h:32:9: warning: unused variable ‘nprot’ [-Wunused-variable]
     int nprot = 0;                                                                               \
         ^~~~~
/usr/local/lib/R-devel/lib/R/library/Rcpp/include/Rcpp/macros/macros.h:32:9: note: in definition of macro ‘BEGIN_RCPP’
     int nprot = 0;                                                                               \
         ^~~~~
/usr/local/lib/R-devel/lib/R/library/Rcpp/include/Rcpp/macros/macros.h:36:17: warning: unused variable ‘stop_sym’ [-Wunused-variable]
     static SEXP stop_sym = Rf_install("stop");                                                   \
                 ^~~~~~~~
/usr/local/lib/R-devel/lib/R/library/Rcpp/include/Rcpp/macros/macros.h:36:17: note: in definition of macro ‘BEGIN_RCPP’
     static SEXP stop_sym = Rf_install("stop");                                                   \
                 ^~~~~~~~

@romainfrancois @lionel- @kevinushey Any better idea than inserting a fake check or use?
Seems silly to waste cycles on this. Can we add a sentinel function just to fake the compiler?

[eddelbuettel]

I think I have a fix. The 'other' macro END_RCPP_RETURN_ERROR needs both symbols added.

[eddelbuettel]

modified   inst/include/Rcpp/macros/macros.h
@@ -98,7 +98,10 @@
   catch (...) {                                                                \
     return string_to_try_error("c++ exception (unknown reason)");              \
   }                                                                            \
-  return R_NilValue;
+  UNPROTECT(nprot);                                                            \
+  return R_NilValue;                                                           \
+  if (stop_sym == R_NilValue) /* never reached but */                          \
+    return R_NilValue;        /* suppresses warning*/
 #endif
 
 #define Rcpp_error(MESSAGE) throw Rcpp::exception(MESSAGE, __FILE__, __LINE__)

[kevinushey]

I'll take a look as well.

[eddelbuettel]

That actually takes care of things and I'll PR it later once I get home...

[kevinushey]

Sounds good (can confirm your fix looks good as well)

[eddelbuettel]

@kevinushey Now committed and put into PR #953