-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noisy installations of Rcpp 1.0.1 due to changes in RcppExports.cpp #951
Comments
I think I have a fix. The 'other' macro |
modified inst/include/Rcpp/macros/macros.h
@@ -98,7 +98,10 @@
catch (...) { \
return string_to_try_error("c++ exception (unknown reason)"); \
} \
- return R_NilValue;
+ UNPROTECT(nprot); \
+ return R_NilValue; \
+ if (stop_sym == R_NilValue) /* never reached but */ \
+ return R_NilValue; /* suppresses warning*/
#endif
#define Rcpp_error(MESSAGE) throw Rcpp::exception(MESSAGE, __FILE__, __LINE__)
|
I'll take a look as well. |
That actually takes care of things and I'll PR it later once I get home... |
Sounds good (can confirm your fix looks good as well) |
@kevinushey Now committed and put into PR #953 |
eddelbuettel
added a commit
that referenced
this issue
Mar 19, 2019
use nprot and reference stop_sym (closes #951)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@romainfrancois @lionel- @kevinushey Any better idea than inserting a fake check or use?
Seems silly to waste cycles on this. Can we add a sentinel function just to fake the compiler?
The text was updated successfully, but these errors were encountered: