Skip to content

test for and report unavailable package in linkingto (closes #1026) #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

test for and report unavailable package in linkingto (closes #1026) #1027

merged 1 commit into from
Nov 21, 2019

Conversation

eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Nov 21, 2019 •
edited
Loading

This addresses #1026 and checks against an empty path for LinkingTo if a non-exsting package is referenced from cppFunction(..., depends=...).

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

kevinushey
kevinushey approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit d3d8729 into master Nov 21, 2019
@eddelbuettel eddelbuettel deleted the feature/cppdepends_path_check branch November 21, 2019 15:51
@eddelbuettel
Copy link
Member Author

A quick test for #1026 has been added in 37c390e which will go in a (large) PR in a sec.

eddelbuettel added a commit that referenced this pull request Nov 25, 2019
@eddelbuettel
add test for #1026 / #1027: cppFunction with non-exist pkg
37c390e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinushey kevinushey kevinushey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddelbuettel @coatless @kevinushey