Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions impl fixes #1055

Merged
merged 4 commits into from
Mar 22, 2020
Merged

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Mar 22, 2020

Some fixes for inst/include/Rcpp/exceptions_impl.h

  • the header file should have an include guard like all the other headers.
  • The RCPP_DEMANGLER_ENABLED should always have a value - missing #else
  • demangler_one should have an inline qualifier. Without this ROOT's R interface complains:

Processing /builddir/build/BUILD/root-6.20.02/tutorials/r/Function.C...
IncrementalExecutor::executeFunction: symbol '_ZN4RcppL13demangler_oneEPKc' unresolved
while linking [cling interface function]!
You are probably missing the definition of Rcpp::demangler_one(char const*)
Maybe you need to load the corresponding shared library?

With the inline qualifier this error disappears.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for catching those.

@eddelbuettel
Copy link
Member

Thumbs up, and thanks, from me too. Looks like we are breaking all sorts of (internal) record with that recent exceptions PR needing an unheard number of follow-ups 😭

Can you detail what makes ROOT's setup different so that it tripped here when this did not show anywhere else, including at CRAN?

@eddelbuettel eddelbuettel merged commit d2cfd85 into RcppCore:master Mar 22, 2020
@ellert ellert deleted the exceptions-impl-fixes branch March 22, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants