Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add echo parameter to sourcecpp #1138

Merged
merged 4 commits into from
Jan 23, 2021
Merged

Conversation

eddelbuettel
Copy link
Member

This is a twoofer which cleans up the earlier #1126 with a new parameter echo that defaults to TRUE (old behaviour) and is passed on to source() to make any optional R code submitted to sourceCpp() or cppFunction() silent. It also cleans up the simple DataFrame warning in #1137.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel
Copy link
Member Author

Yes, it's slowly churning through yet another rev.dep run and of course no issues there either. May wait, or may merge sooner. Thanks for the thumbs-up.

@eddelbuettel
Copy link
Member Author

Uneventfule rev.dep run, as expected: RcppCore/rcpp-logs@223d559 so merging now.

@eddelbuettel eddelbuettel merged commit 98173e5 into master Jan 23, 2021
@eddelbuettel eddelbuettel deleted the feature/echo_param_sourcecpp branch January 23, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants