Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signature attribute; small cleanup #1187

Merged
merged 1 commit into from
Oct 26, 2021
Merged

signature attribute; small cleanup #1187

merged 1 commit into from
Oct 26, 2021

Conversation

traversc
Copy link
Contributor

Two small changes to pr/1183 based on @kevinushey 's comments.

  1. Check sig.empty() before calling sig.front() and sig.back()

  2. Change -1 to std::string:npos for stylistic reasons.

Checks using github actions still pass: https://github.com/traversc/Rcpp/runs/4003616100?check_suite_focus=true

@eddelbuettel eddelbuettel merged commit 2f4280a into RcppCore:pr/1183 Oct 26, 2021
@eddelbuettel
Copy link
Member

Looks good. Let me wrap up what we have now in #1183 and throw it again at the rev.dep machine. Not expecting anything nefarious as unit tests rarely call compileAttributes() but it does not hurt to stick with the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants