Skip to content

Conversation

bbolker
Copy link
Contributor

@bbolker bbolker commented Jan 18, 2025

No description provided.

Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much! Care to add yourself and this change to ChangeLog? C-x 4 a from the file makes it pretty easy in case you use that editor...

@bbolker
Copy link
Contributor Author

bbolker commented Jan 18, 2025

done. I'm not very experienced at squashing commits. If that's a thing you care about I could either figure out how to do that, or delete this PR and push a new one ...

@eddelbuettel
Copy link
Member

eddelbuettel commented Jan 18, 2025

Squashing is the best. Nomatter how many individual ones you pile up we end up with one.

(I became a fan of amending commits though when 'n + 1' is just a subtle refinement of 'n' and to then force-push (if in branch / fork))

(So when I squash in a minute or two you will have three lines for the three commits in the expanded commit message. Someone sufficiently type-a to not want three could simply do a standard git squashing to reduce the three to two or one. It lets you. Squash-merge added that to the web ui.)

@eddelbuettel eddelbuettel changed the title fix trivial typos in NEWS Fix trivial typos in NEWS Jan 18, 2025
@eddelbuettel eddelbuettel merged commit 55a4f01 into RcppCore:master Jan 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants